Skip to content

Conversation

@raymond1242
Copy link
Contributor

Description

Add a search in ProjectListPage view

Issue

* Github Issue ID.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@raymond1242 raymond1242 added the enhancement New feature or request label Sep 12, 2023
@raymond1242 raymond1242 requested a review from mgonnav September 12, 2023 13:12
@raymond1242 raymond1242 self-assigned this Sep 12, 2023
@raymond1242 raymond1242 marked this pull request as ready for review September 19, 2023 01:12
Copy link
Contributor

@mgonnav mgonnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search works fine in that it returns the related projects correctly. However, if I have 100 projects that match the search, it returns the 100 projects on a single page. The results should be paginated by the backend and should be able to paginate in the frontend only the related results. Just like in GitHub.

@raymond1242 raymond1242 requested a review from mgonnav September 27, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants