From 714e07dcc6981f3c189b151709f186285d0627de Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 10:49:27 +0000 Subject: [PATCH 1/4] Initial plan From 1cc6874c92eafdeda7a0f20f63044f333ed5bea0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 10:53:44 +0000 Subject: [PATCH 2/4] Move 'arg' variable to detail namespace (issue #150) Co-authored-by: vprus <225915+vprus@users.noreply.github.com> --- include/boost/program_options/detail/value_semantic.hpp | 6 ++++-- src/value_semantic.cpp | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/include/boost/program_options/detail/value_semantic.hpp b/include/boost/program_options/detail/value_semantic.hpp index 80e292510..27b7c241b 100644 --- a/include/boost/program_options/detail/value_semantic.hpp +++ b/include/boost/program_options/detail/value_semantic.hpp @@ -17,13 +17,15 @@ namespace boost { template class optional; } namespace boost { namespace program_options { - extern BOOST_PROGRAM_OPTIONS_DECL std::string arg; + namespace detail { + extern BOOST_PROGRAM_OPTIONS_DECL std::string arg; + } template std::string typed_value::name() const { - std::string const& var = (m_value_name.empty() ? arg : m_value_name); + std::string const& var = (m_value_name.empty() ? detail::arg : m_value_name); if (!m_implicit_value.empty() && !m_implicit_value_as_text.empty()) { std::string msg = "[=" + var + "(=" + m_implicit_value_as_text + ")]"; if (!m_default_value.empty() && !m_default_value_as_text.empty()) diff --git a/src/value_semantic.cpp b/src/value_semantic.cpp index de7b2ace8..c4feb688e 100644 --- a/src/value_semantic.cpp +++ b/src/value_semantic.cpp @@ -84,12 +84,14 @@ namespace boost { namespace program_options { } #endif - BOOST_PROGRAM_OPTIONS_DECL std::string arg("arg"); + namespace detail { + BOOST_PROGRAM_OPTIONS_DECL std::string arg("arg"); + } std::string untyped_value::name() const { - return arg; + return detail::arg; } unsigned From 976f3d7b06c6bedc9136a36a663dee6d84badaeb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 10:54:56 +0000 Subject: [PATCH 3/4] Complete PR for moving arg variable to detail namespace Co-authored-by: vprus <225915+vprus@users.noreply.github.com> --- _codeql_detected_source_root | 1 + 1 file changed, 1 insertion(+) create mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root new file mode 120000 index 000000000..945c9b46d --- /dev/null +++ b/_codeql_detected_source_root @@ -0,0 +1 @@ +. \ No newline at end of file From 255c207e3a2dbb0a673ac56d5dff85c6e20993ce Mon Sep 17 00:00:00 2001 From: Vladimir Prus Date: Thu, 4 Dec 2025 11:01:13 +0000 Subject: [PATCH 4/4] Delete _codeql_detected_source_root --- _codeql_detected_source_root | 1 - 1 file changed, 1 deletion(-) delete mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root deleted file mode 120000 index 945c9b46d..000000000 --- a/_codeql_detected_source_root +++ /dev/null @@ -1 +0,0 @@ -. \ No newline at end of file