Skip to content

Commit aba266c

Browse files
authored
refactor: adiciona suporte a anotações modernas em phone.py (#636)
* refactor: add type hints to phone number functions * Add type hint none to format_phone return
1 parent 867d8c6 commit aba266c

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

brutils/phone.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
# FORMATTING
66
############
7-
def format_phone(phone): # type: (str) -> str
7+
def format_phone(phone: str) -> str | None:
88
"""
99
Function responsible for formatting a telephone number
1010
@@ -34,7 +34,7 @@ def format_phone(phone): # type: (str) -> str
3434
############
3535

3636

37-
def is_valid(phone_number, type=None): # type: (str, str) -> bool
37+
def is_valid(phone_number: str, type: str = None) -> bool:
3838
"""
3939
Returns if a Brazilian phone number is valid.
4040
It does not verify if the number actually exists.
@@ -58,7 +58,7 @@ def is_valid(phone_number, type=None): # type: (str, str) -> bool
5858
return _is_valid_landline(phone_number) or _is_valid_mobile(phone_number)
5959

6060

61-
def remove_symbols_phone(phone_number): # type: (str) -> str
61+
def remove_symbols_phone(phone_number: str) -> str:
6262
"""
6363
Removes common symbols from a Brazilian phone number string.
6464
@@ -80,7 +80,7 @@ def remove_symbols_phone(phone_number): # type: (str) -> str
8080
return cleaned_phone
8181

8282

83-
def generate(type=None): # type: (str) -> str
83+
def generate(type: str = None) -> str:
8484
"""
8585
Generate a valid and random phone number.
8686
@@ -110,7 +110,7 @@ def generate(type=None): # type: (str) -> str
110110
return choice(generate_functions)()
111111

112112

113-
def remove_international_dialing_code(phone_number): # type: (str) -> str
113+
def remove_international_dialing_code(phone_number: str) -> str:
114114
"""
115115
Function responsible for remove a international code phone
116116
@@ -141,7 +141,7 @@ def remove_international_dialing_code(phone_number): # type: (str) -> str
141141
return phone_number
142142

143143

144-
def _is_valid_mobile(phone_number: str): # type: (str) -> bool
144+
def _is_valid_mobile(phone_number: str) -> bool:
145145
"""
146146
Returns if a Brazilian mobile number is valid.
147147
It does not verify if the number actually exists.
@@ -162,7 +162,7 @@ def _is_valid_mobile(phone_number: str): # type: (str) -> bool
162162
)
163163

164164

165-
def _is_valid_landline(phone_number: str): # type: (str) -> bool
165+
def _is_valid_landline(phone_number: str) -> bool:
166166
"""
167167
Returns if a Brazilian landline number is valid.
168168
It does not verify if the number actually exists.
@@ -183,14 +183,14 @@ def _is_valid_landline(phone_number: str): # type: (str) -> bool
183183
)
184184

185185

186-
def _generate_ddd_number(): # type() -> str
186+
def _generate_ddd_number() -> str:
187187
"""
188188
Generate a valid DDD number.
189189
"""
190190
return f'{"".join([str(randint(1, 9)) for i in range(2)])}'
191191

192192

193-
def _generate_mobile_phone():
193+
def _generate_mobile_phone() -> str:
194194
"""
195195
Generate a valid and random mobile phone number
196196
"""
@@ -202,7 +202,7 @@ def _generate_mobile_phone():
202202
return phone_number
203203

204204

205-
def _generate_landline_phone(): # type () -> str
205+
def _generate_landline_phone() -> str:
206206
"""
207207
Generate a valid and random landline phone number.
208208
"""

0 commit comments

Comments
 (0)