Skip to content

Close connection during garbage collection #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2016
Merged

Close connection during garbage collection #684

merged 3 commits into from
Feb 16, 2016

Conversation

@cbandy
Copy link
Contributor

@cbandy cbandy commented Sep 25, 2015

Restores the behavior of v0.3.15 which sends QUIT during garbage collection. Keep the behavior in #463 behind a new connection option, automatic_close.

Relates to #606.

sodabrew
sodabrew reviewed Jan 16, 2016
View reviewed changes
lib/mysql2/client.rb Outdated
Copy link
Collaborator

@sodabrew sodabrew Jan 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add :automatic_close to the list of booleans.

Copy link
Contributor Author

@cbandy cbandy Jan 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. automatic_close= already does the conversion using RTEST.

Copy link
Contributor Author

@cbandy cbandy Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

sodabrew
sodabrew reviewed Jan 21, 2016
View reviewed changes
ext/mysql2/client.c Outdated
Copy link
Collaborator

@sodabrew sodabrew Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid re-using the variable value, since we're not modifying the argument and shouldn't give the impression that we might be trying to do that.

Copy link
Contributor Author

@cbandy cbandy Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the return value from assignment is usually ignored, I'll change this to return the unmodified input value.

Copy link
Contributor Author

@cbandy cbandy Jan 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sodabrew sodabrew added this to the 0.4.3 milestone Jan 21, 2016
@sodabrew
Copy link
Collaborator

sodabrew commented Jan 21, 2016

Thanks for your patience on this! I'm collecting the todo list for 0.4.3 and I'm keen to include this PR!

@cbandy
Copy link
Contributor Author

cbandy commented Jan 23, 2016

The testing of $stderr works in Linux, but I don't have a Windows machine or build server to try it on. Do you?

@sodabrew
Copy link
Collaborator

sodabrew commented Jan 23, 2016 via email

sodabrew added a commit that referenced this pull request Feb 16, 2016
@sodabrew
Merge pull request #684 from cbandy/close-during-gc
924d934 
Close connection during garbage collection
@sodabrew sodabrew merged commit 924d934 into brianmario:master Feb 16, 2016
@cbandy cbandy deleted the close-during-gc branch October 28, 2016 17:52
@adamstegman adamstegman mentioned this pull request Feb 13, 2017
Merged
@matthewd matthewd mentioned this pull request Nov 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.3

Development

Successfully merging this pull request may close these issues.

2 participants

@cbandy @sodabrew