remove stray NumberErrbacks, and fix calls to gcd to no longer pass an array of values as second argument

Author: Ben Lerner

src/js/base/js-numbers.js

@@ -1007,7 +1007,7 @@ define("pyret-base/js/js-numbers", function() {
       } else if (isRational(x) && isRational(y)) {
         var xn = numerator(x); var xd = denominator(x);
         var yn = numerator(y); var yd = denominator(y);
-        var new_d = lcm(xd, [yd]);
+        var new_d = lcm(xd, yd);
         var new_xn = multiply(xn, divide(new_d, xd));
         var new_yn = multiply(yn, divide(new_d, yd));
         return divide(remainder(new_xn, new_yn), new_d);

src/js/base/runtime.js

@@ -5229,14 +5229,14 @@ function (Namespace, jsnumslib, codePoint, util, exnStackParser, loader, seedran
       if (arguments.length !== 2) { var $a=new Array(arguments.length); for (var $i=0;$i<arguments.length;$i++) { $a[$i]=arguments[$i]; } throw thisRuntime.ffi.throwArityErrorC(["num-gcd"], 2, $a, false); }
       thisRuntime.checkArgsInternal2("Numbers", "num-gcd",
         n, thisRuntime.Number, m, thisRuntime.Number);
-      return thisRuntime.makeNumberBig(jsnums.gcd(n, m, NumberErrbacks));
+      return thisRuntime.makeNumberBig(jsnums.gcd(n, m));
     }
 
     var num_lcm = function(n, m) {
       if (arguments.length !== 2) { var $a=new Array(arguments.length); for (var $i=0;$i<arguments.length;$i++) { $a[$i]=arguments[$i]; } throw thisRuntime.ffi.throwArityErrorC(["num-lcm"], 2, $a, false); }
       thisRuntime.checkArgsInternal2("Numbers", "num-lcm",
         n, thisRuntime.Number, m, thisRuntime.Number);
-      return thisRuntime.makeNumberBig(jsnums.lcm(n, m, NumberErrbacks));
+      return thisRuntime.makeNumberBig(jsnums.lcm(n, m));
     }
 
     var num_sqrt = function(n) {

src/js/trove/charts-lib.js

@@ -144,22 +144,22 @@
           ret[rawVal] = num;
         }
       }
-      if (jsnums.greaterThanOrEqual(ret.xMinValue, ret.xMaxValue, RUNTIME.NumberErrbacks)) {
+      if (jsnums.greaterThanOrEqual(ret.xMinValue, ret.xMaxValue)) {
         raw.xMinValue.addClass('error-bg');
         raw.xMaxValue.addClass('error-bg');
         raw.xMinValue.removeClass('ok-bg');
         raw.xMaxValue.removeClass('ok-bg');
         return null;
       }
-      if (jsnums.greaterThanOrEqual(ret.yMinValue, ret.yMaxValue, RUNTIME.NumberErrbacks)) {
+      if (jsnums.greaterThanOrEqual(ret.yMinValue, ret.yMaxValue)) {
         raw.yMinValue.addClass('error-bg');
         raw.yMaxValue.addClass('error-bg');
         raw.yMinValue.removeClass('ok-bg');
         raw.yMaxValue.removeClass('ok-bg');
         return null;
       }
       if (!isTrue(RUNTIME.num_is_integer(ret.numSamples)) ||
-          jsnums.lessThanOrEqual(ret.numSamples, 1, RUNTIME.NumberErrbacks)) {
+          jsnums.lessThanOrEqual(ret.numSamples, 1)) {
         raw.numSamples.addClass('error-bg');
         raw.numSamples.removeClass('ok-bg');
         return null;

src/js/trove/image-lib.js

@@ -141,8 +141,8 @@
 
     var isAngle = function(x) {
       return jsnums.isReal(x) &&
-        jsnums.greaterThanOrEqual(x, 0, RUNTIME.NumberErrbacks) &&
-        jsnums.lessThan(x, 360, RUNTIME.NumberErrbacks);
+        jsnums.greaterThanOrEqual(x, 0) &&
+        jsnums.lessThan(x, 360);
     };
 
     // Produces true if the value is a color or a color string.
@@ -229,15 +229,15 @@
 
 
     var isSideCount = function(x) {
-      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 3, RUNTIME.NumberErrbacks);
+      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 3);
     };
 
     var isStepCount = function(x) {
-      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 1, RUNTIME.NumberErrbacks);
+      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 1);
     };
 
     var isPointsCount = function(x) {
-      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 2, RUNTIME.NumberErrbacks);
+      return jsnums.isInteger(x) && jsnums.greaterThanOrEqual(x, 2);
     };
 
     // Produces true if thing is an image-like object.
@@ -1333,7 +1333,7 @@
 
       // rotate around outer circle, storing x and y coordinates
       var radians = 0, vertices = [];
-      var numComponents = jsnums.gcd(count, [step], RUNTIME.NumberErrbacks);
+      var numComponents = jsnums.gcd(count, step);
       var pointsPerComponent = count / numComponents;
       var angle = (2*Math.PI/count);
       for (var curComp = 0; curComp < numComponents; curComp++) {