-
Notifications
You must be signed in to change notification settings - Fork 29
Fix/mobile random values #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🏁 Benchmark Comparison (Node 22)Comparing this PR (bac08c5) against master (726e75d). ✅ No regressions over the 5% threshold detected.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes the React Native-specific polyfill detection and loading code from Random.ts. The change eliminates the dependency on react-native-get-random-values, allowing React Native projects to use alternative crypto polyfills like react-native-quick-crypto that populate the standard globalThis.crypto API instead.
Key Changes
- Removed React Native-specific polyfill detection and auto-loading logic from
Random.ts - Updated documentation to remove references to
react-native-get-random-valuesrequirement - Bumped version to 1.9.11
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/primitives/Random.ts | Removed React Native polyfill detection and loading code; simplified to rely on standard crypto APIs |
| package.json | Version bumped to 1.9.11 |
| package-lock.json | Version bumped to 1.9.11 |
| CHANGELOG.md | Added entry for version 1.9.11 documenting the polyfill removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🏁 Benchmark Comparison (Node 22)Comparing this PR (ba54643) against master (73b6ae6). ✅ No regressions over the 5% threshold detected. 🎉 1 significant speedup (>5% faster). Speedups
|



Description of Changes
Getting build errors in mobile arch when quick crypto is being used rather than react-native-get-random-values
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist
CHANGELOG.mdwith my changesnpm run docandnpm run lintone final time before requesting a reviewts-standardnpm version patchso that my changes will trigger a new version to be released when they are merged