Skip to content

Commit 8a70db4

Browse files
Merge pull request #2069 from bugsnag/PLAT-11222/release-script-dist-tag
Make `DIST_TAG` a required env var when releasing
2 parents c61d9b2 + ce0f11e commit 8a70db4

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ AWS_ACCESS_KEY_ID=xxx \
9797
AWS_SECRET_ACCESS_KEY=xxx \
9898
RELEASE_BRANCH=master \
9999
VERSION=patch \
100+
DIST_TAG=latest \
100101
docker-compose run release
101102
```
102103

@@ -142,6 +143,7 @@ AWS_ACCESS_KEY_ID=xxx \
142143
AWS_SECRET_ACCESS_KEY=xxx \
143144
RELEASE_BRANCH=master \
144145
VERSION=preminor \
146+
DIST_TAG=next \
145147
docker-compose run release
146148
```
147149
@@ -165,6 +167,8 @@ GITHUB_ACCESS_TOKEN=<generate a personal access token> \
165167
AWS_ACCESS_KEY_ID=xxx \
166168
AWS_SECRET_ACCESS_KEY=xxx \
167169
RELEASE_BRANCH=master \
170+
VERSION=patch \
171+
DIST_TAG=latest \
168172
RETRY_PUBLISH=1 \
169173
FORCE_CDN_UPLOAD=1 \
170174
docker-compose run release

bin/release.sh

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ if [[ -z ${GITHUB_USER:-} ]]; then error_missing_field "GITHUB_USER"; fi
1212
if [[ -z ${GITHUB_ACCESS_TOKEN:-} ]]; then error_missing_field "GITHUB_ACCESS_TOKEN"; fi
1313
if [[ -z ${RELEASE_BRANCH:-} ]]; then error_missing_field "RELEASE_BRANCH"; fi
1414
if [[ -z ${VERSION:-} ]]; then error_missing_field "VERSION"; fi
15+
if [[ -z ${DIST_TAG:-} ]]; then error_missing_field "DIST_TAG"; fi
1516
if [[ -z ${AWS_ACCESS_KEY_ID:-} ]]; then error_missing_field "AWS_ACCESS_KEY_ID"; fi
1617
if [[ -z ${AWS_SECRET_ACCESS_KEY:-} ]]; then error_missing_field "AWS_SECRET_ACCESS_KEY"; fi
1718
if [[ -z ${AWS_SESSION_TOKEN:-} ]]; then error_missing_field "AWS_SESSION_TOKEN"; fi
@@ -51,17 +52,9 @@ git push origin --follow-tags
5152

5253
# publish
5354
if [ -v RETRY_PUBLISH ]; then
54-
npx lerna publish from-package
55+
npx lerna publish from-package --dist-tag "$DIST_TAG"
5556
else
56-
case $VERSION in
57-
"prerelease" | "prepatch" | "preminor" | "premajor")
58-
npx lerna publish from-git --dist-tag next
59-
;;
60-
61-
*)
62-
npx lerna publish from-git
63-
;;
64-
esac
57+
npx lerna publish from-git --dist-tag "$DIST_TAG"
6558
fi
6659

6760
if [ "$BROWSER_PACKAGE_CHANGED" -eq 1 ] || [ -v FORCE_CDN_UPLOAD ]; then

0 commit comments

Comments
 (0)