Skip to content

Conversation

@shcherbanich
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added/updated tests.

@shcherbanich
Copy link
Contributor Author

@seanmcn It seems that everything is fine here, before the release of the 2.x version it is better to apply these changes.. But it’s better to check it first, can you please do this? :)

@shcherbanich shcherbanich marked this pull request as ready for review April 5, 2024 12:09
@shcherbanich shcherbanich requested a review from seanmcn April 5, 2024 12:09
@seanmcn
Copy link
Collaborator

seanmcn commented Apr 18, 2024

One thing that's a bit strange to me, and this is probably more to do with the 2.x.x branch than this PR is now if I run:

php demo/demo1/demoScript.php

I get:

Generation completed with errors
├───────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ERROR │ Configuration parameter `language_handlers.php.settings.composer_config_file` must contain exists file path │
│       │ This error occurs during the document rendering process                                                     │
│       │ /src/Core/Plugin/PluginEventDispatcher.php#32                                                               │
│       │ /sectionWithSubsections/pageLinkingExample/index.md.twig                                                    │

Do I need to pass this in manually now or?

@shcherbanich
Copy link
Contributor Author

@seanmcn For some reason I can't reply to the thread. The error in php demo/demo1/demoScript.php occurs because the demo config has not been corrected, it just needs to be corrected and the necessary option added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants