[Feature] pop-up when you hit download

[corgi-in-tights]

just a small addition, happy to PR, an alert or some pop-up when you hit download (and its successfully queued) would be nice to know for sure, otherwise I have to go manually check or sometimes accidentally click twice.

[calibrain]

Sure sent a PR my way and ill approve it !

[corgi-in-tights]

do you mind if i re-organize the project to fit modern flask conventions? ie app and config dirs, move README_images to docs/images, merge config.py and env.py before anything? i wanted to add openid auth and all too but its a bit messy for my tastes right now :p

ill make the PR sometime this week and keep all the code the same, just clean stuff up and you can modify/copy it as you see fit

example structure:
docs/
|
src/
├─ app/
│ ├─ init.py
│ ├─ routes.py
│ ├─ templates/
│ ├─ static/
│ └─ models.py
etc. etc.
│
├─ config/
│ └─ settings.py
│
├─ utils/
│ └─ logger.py
│
├─ jobs/
│ ├─ backend.py
│ └─ cloudflare_bypasser.py
│
tests/
└─ ...

its a bit much and very invasive (though industry-standard) but it pains me to see the current repo

[corgi-in-tights]

itll require a manual merge for almost everything if you have anything in-progress but i was really looking for a feature-rich abstraction for anna's like jellyseerr for jellyfin (ratelimits, local users, auth, etc.)

CWA-BD is really close but its mainly the lack of auth & UX, both of which I think reasonably need a better structure to avoid monolithic spaghettification or future bugs

openid auth is a big overhead though im perfectly fine with ratelimited local users + support for reverse proxy/header authentication and maybe some better search filters, happy to try my hand at 'em but as i said, clean up first

[calibrain]

I have a few stuff going on, mainly some network refactor
But please, go on
I don't mind refactors, and this project really needs one (its basically a weekend vibe code that grew too quick for its own good lol)

So don't worry and send a PR !

[corgi-in-tights]

Ignore the errors and warnings, I was thinking something like this? Might split up some of the service files a bit more and throw some classes in there, dunno

Should be done by next week~ish, some minor stuff like models.py being in services/ is just placeholder for now, will find a better spot later, mostly mean the directories

Went for the more modern (in my opinion) src/app and src/config setup over app/ and config/ with a wsgi.py and django-style conf.py

[calibrain]

Looks good ! Thank you for the hard work !

[ronnoceel]

Suggestion for implementation:
When a user clicks the download button, have it change to a loading circle and disable the button. when the page gets confirmation that it is downloading the book, change the circle to a checkmark.

ETA: If after the refactor you don't feel like actually doing this, I can give it a go.

[corgi-in-tights]

Suggestion for implementation: When a user clicks the download button, have it change to a loading circle and disable the button. when the page gets confirmation that it is downloading the book, change the circle to a checkmark.

Okay, should be done by Saturday -- bit of a delay as some of the code is uh.. messy to say the least and refactoring is taking a bit, though I'm not touching network.py

[opswhisperer]

came here to see if anyone was working on the download button 👍🏻 I must have clicked it 10 times thinking it wasn't working. Anything would work, pop up, button animation - anything to indicate the click registered

[corgi-in-tights]

I may have gone a bit overboard with the refactoring

I'll be honest, this is starting to feel a bit like the Ship of Theseus. I'm not sure if I should just fork the project entirely or PR but I'll try the former first -- might be a bit too much effort to read, test and adapt to. Not too much right now but I'm only about.. halfway done.

No offence and I know its a bit of a patch project but the codebase was really messy, close to a full remake at this point.

[calibrain]

No worries !
This whole project started as just a weekend project of me wanting to give access to my library to a friend, and I open sourced.
Then issue by issue, it started growing, and since I never had any real direction on where the project is going, or time line, I just went on implementing / fixing issues as they came, it became a huge mess
I appreciate all the effort you are putting in organizing everything and refactoring !

And to be fair, as long as the core logic still works, I am not opposed to merging large changes !

[alexhb1]

This should be solved with #301 and #302 now :)

[opswhisperer]

When will the image be updated?

[alexhb1]

@opswhisperer You should be able to use the dev branch in the meantime

https://github.com/calibrain/calibre-web-automated-book-downloader/pkgs/container/calibre-web-automated-book-downloader/578622336?tag=dev