docs: ensure its clear one should deploy workers with the containerd relation #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation to clarify that the containerd relation should be deployed on worker nodes, addressing issue #755. The changes add a new subsection explaining how to share the containerd configuration with all worker applications in the cluster.
Key Changes:
- Added "Sharing with all workers in the cluster" subsection with explanation and bash example
- Includes a bash loop to automatically integrate containerd with all k8s-worker applications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
addyess
commented
Nov 21, 2025
addyess
force-pushed
the
KU-4805/docs/improve-containerd-integration
branch
from
f2189d6 to
c28c247
Compare
addyess
force-pushed
the
KU-4805/docs/improve-containerd-integration
branch
from
c28c247 to
b2591c3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Adam Dyess <[email protected]>
addyess
force-pushed
the
KU-4805/docs/improve-containerd-integration
branch
from
328e21d to
3326e98
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ktsakalozos
reviewed
Nov 26, 2025
addyess
force-pushed
the
KU-4805/docs/improve-containerd-integration
branch
from
e889b50 to
f1a64e3
Compare
nhennigan
reviewed
Dec 1, 2025
nhennigan
approved these changes
Dec 2, 2025
Contributor
nhennigan
left a comment
nhennigan
left a comment
There was a problem hiding this comment.
Thanks Adam. Please also backport to 1.34, 1.33 and 1.32
Collaborator
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…relation (#2071) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md Co-authored-by: Copilot <[email protected]> * Integration suggestions Signed-off-by: Adam Dyess <[email protected]> * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]> (cherry picked from commit a337b01)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…relation (#2071) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md Co-authored-by: Copilot <[email protected]> * Integration suggestions Signed-off-by: Adam Dyess <[email protected]> * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]> (cherry picked from commit a337b01)
Collaborator
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…relation (#2071) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md Co-authored-by: Copilot <[email protected]> * Integration suggestions Signed-off-by: Adam Dyess <[email protected]> * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]> (cherry picked from commit a337b01)
Collaborator
|
Successfully created backport PR for |
addyess
added a commit
that referenced
this pull request
Dec 3, 2025
…relation (#2071) (#2107) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md * Integration suggestions * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- (cherry picked from commit a337b01) Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]>
addyess
added a commit
that referenced
this pull request
Dec 3, 2025
…relation (#2071) (#2108) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md * Integration suggestions * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- (cherry picked from commit a337b01) Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]>
addyess
added a commit
that referenced
this pull request
Dec 3, 2025
…relation (#2071) (#2109) * docs: ensure its clear one should deploy workers with the containerd relation * Update docs/canonicalk8s/charm/howto/custom-registry.md * Integration suggestions * How-to documentation should be more prescriptive and less choose-your-own-way * Integrate review comments --------- (cherry picked from commit a337b01) Signed-off-by: Adam Dyess <[email protected]> Co-authored-by: Adam Dyess <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the documentation around the containerd relation according to
canonical/k8s-operator#755
Solution
Adds a section to the docs to highlight integrating with containerd on all workers
Issue
canonical/k8s-operator#755.
Checklist
type: title