configure: drop JIT logic, which is not needed anymore with the sd-generator

This was originally implemented to generate & start systemd units just-in-time
during the boot transaction (#162).

With the implementation of a proper systemd-generator, Netplan generates the
corresponding units in /run/system/generator* and automatically re-loads and
re-calculates dependencies during "daemon-reload". Therefore, we do not need
to inject them manually.

This is covered by the "cloud-init" autopkgtest.

Author: slyon

src/configure.c

@@ -54,38 +54,6 @@ static GOptionEntry options[] = {
     {NULL}
 };
 
-// LCOV_EXCL_START
-/* covered via 'cloud-init' integration test */
-static gboolean
-check_called_just_in_time()
-{
-    const gchar *argv[] = { "/bin/systemctl", "is-system-running", NULL };
-    gchar *output = NULL;
-    g_spawn_sync(NULL, (gchar**)argv, NULL, G_SPAWN_STDERR_TO_DEV_NULL, NULL, NULL, &output, NULL, NULL, NULL);
-    if (output != NULL && strstr(output, "initializing") != NULL) {
-        g_free(output);
-        const gchar *argv2[] = { "/bin/systemctl", "is-active", "network.target", NULL };
-        gint exit_code = 0;
-        g_spawn_sync(NULL, (gchar**)argv2, NULL, G_SPAWN_STDERR_TO_DEV_NULL, NULL, NULL, NULL, NULL, &exit_code, NULL);
-        /* return TRUE, if network.target is not yet active */
-        #if GLIB_CHECK_VERSION (2, 70, 0)
-        return !g_spawn_check_wait_status(exit_code, NULL);
-        #else
-        return !g_spawn_check_exit_status(exit_code, NULL);
-        #endif
-    }
-    g_free(output);
-    return FALSE;
-};
-
-static void
-start_unit_jit(gchar *unit)
-{
-    const gchar *argv[] = { "/bin/systemctl", "start", "--no-block", "--no-ask-password", unit, NULL };
-    g_spawn_sync(NULL, (gchar**)argv, NULL, G_SPAWN_DEFAULT, NULL, NULL, NULL, NULL, NULL, NULL);
-};
-// LCOV_EXCL_STOP
-
 #define CHECK_CALL(call, ignore_errors) {\
     if (!call && !ignore_errors) {\
         error_code = 1; \
@@ -103,7 +71,6 @@ int main(int argc, char** argv)
     GOptionContext* opt_context;
     g_autofree char* generator_run_stamp = NULL;
     g_autofree char* netplan_try_stamp = NULL;
-    glob_t gl;
     int error_code = 0;
     char* ignore_errors_env = NULL;
     NetplanParser* npp = NULL;
@@ -230,45 +197,7 @@ int main(int argc, char** argv)
 
     if (nm_only) goto cleanup;
 
-    gboolean enable_wait_online = FALSE;
-    if (any_networkd) {
-        // _netplan_networkd_write_wait_online() is currently a no-op in the ./configure binary
-        // _netplan_networkd_generate_wait_online() is for sd-generator late-stage validation, but not writing any files
-        enable_wait_online = _netplan_networkd_generate_wait_online(np_state, NULL, _VALIDATION_ONLY);
-    }
-
-    if (check_called_just_in_time()) {
-        /* netplan-feature: generate-just-in-time */
-        /* When booting with cloud-init, network configuration
-         * might be provided just-in-time. Specifically after
-         * system-generators were executed, but before
-         * network.target is started. In such case, auxiliary
-         * units that netplan enables have not been included in
-         * the initial boot transaction. Detect such scenario and
-         * add all netplan units to the initial boot transaction.
-         */
-        // LCOV_EXCL_START
-        /* covered via 'cloud-init' integration test */
-        start_unit_jit("netplan-configure.service");
-        if (any_networkd) {
-            start_unit_jit("systemd-networkd.socket");
-            if (enable_wait_online)
-                start_unit_jit("systemd-networkd-wait-online.service");
-            start_unit_jit("systemd-networkd.service");
-        }
-        g_autofree char* glob_run = g_build_path(G_DIR_SEPARATOR_S,
-                                                 rootdir != NULL ? rootdir : G_DIR_SEPARATOR_S,
-                                                 "run", "systemd", "generator.late", "netplan-*.service",
-                                                 NULL);
-        if (!glob(glob_run, 0, NULL, &gl)) {
-            for (size_t i = 0; i < gl.gl_pathc; ++i) {
-                gchar *unit_name = g_path_get_basename(gl.gl_pathv[i]);
-                start_unit_jit(unit_name);
-                g_free(unit_name);
-            }
-        }
-        // LCOV_EXCL_STOP
-    }
+    // Only logic that is not relevant for NetworkManager config below this point
 
 cleanup:
     g_option_context_free(opt_context);