temp: update tests to use private field

Author: carlaKC

lightning/src/ln/accountable_tests.rs

@@ -2,11 +2,11 @@ use crate::ln::channelmanager::{
 	HTLCForwardInfo, PaymentId, PendingAddHTLCInfo, PendingHTLCInfo, RecipientOnionFields, Retry,
 };
 use crate::ln::functional_test_utils::*;
-use crate::ln::msgs::{accountable_from_bool, ChannelMessageHandler, ExperimentalAccountable};
+use crate::ln::msgs::ChannelMessageHandler;
 use crate::routing::router::{PaymentParameters, RouteParameters};
 
 fn test_accountable_forwarding_with_override(
-	override_accountable: ExperimentalAccountable, expected_forwarded: bool,
+	override_accountable: Option<u8>, expected_forwarded: bool,
 ) {
 	let chanmon_cfgs = create_chanmon_cfgs(3);
 	let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
@@ -32,11 +32,11 @@ fn test_accountable_forwarding_with_override(
 	let updates_ab = get_htlc_update_msgs(&nodes[0], &nodes[1].node.get_our_node_id());
 	assert_eq!(updates_ab.update_add_htlcs.len(), 1);
 	let mut htlc_ab = updates_ab.update_add_htlcs[0].clone();
-	assert_eq!(htlc_ab.accountable, accountable_from_bool(false));
+	assert_eq!(htlc_ab.is_accountable(), false);
 
 	// Override accountable value if requested
-	if let Some(override_value) = override_accountable {
-		htlc_ab.accountable = Some(override_value);
+	if override_accountable.is_some() {
+		htlc_ab.set_accountable(override_accountable)
 	}
 
 	nodes[1].node.handle_update_add_htlc(nodes[0].node.get_our_node_id(), &htlc_ab);
@@ -47,11 +47,11 @@ fn test_accountable_forwarding_with_override(
 	let updates_bc = get_htlc_update_msgs(&nodes[1], &nodes[2].node.get_our_node_id());
 	assert_eq!(updates_bc.update_add_htlcs.len(), 1);
 	let htlc_bc = &updates_bc.update_add_htlcs[0];
-	let expected_acountable_signal = accountable_from_bool(expected_forwarded);
 	assert_eq!(
-		htlc_bc.accountable, expected_acountable_signal,
+		htlc_bc.is_accountable(),
+		expected_forwarded,
 		"B -> C should have accountable = {:?}",
-		expected_acountable_signal
+		expected_forwarded
 	);
 
 	nodes[2].node.handle_update_add_htlc(nodes[1].node.get_our_node_id(), htlc_bc);

lightning/src/ln/msgs.rs

@@ -803,6 +803,12 @@ impl UpdateAddHTLC {
 	pub fn is_accountable(&self) -> bool {
 		self.accountable.is_some_and(|v| v == 7)
 	}
+
+	/// Helper to mutate values in tests.
+	#[cfg(any(test, feature = "_test_utils"))]
+	pub fn set_accountable(&mut self, accountable: Option<u8>) {
+		self.accountable = accountable
+	}
 }
 
 /// An [`onion message`] to be sent to or received from a peer.