Skip to content

Conversation

@igorlfs
Copy link
Contributor

@igorlfs igorlfs commented Oct 14, 2025

Hello,

styles.properties is set as {} in the default config, which is truthy in Lua. Therefore, to actually fall back to italic, users would have to set styles.properties to nil (which I'm assuming is unintended behavior).

Alternatively, @type.builtin could be italic by default.

@comfysage
Copy link
Collaborator

hi, great observation. could you - as you suggested - also set the default option for types to italic?

@igorlfs igorlfs force-pushed the fix/unused-fallback-styles branch from 372f8cf to c2ba250 Compare October 25, 2025 15:11
@igorlfs igorlfs changed the title fix(treesitter): do not set fallback for @type.builtin fix(treesitter): set @type.builtin as italic Oct 25, 2025
@igorlfs
Copy link
Contributor Author

igorlfs commented Oct 25, 2025

also set the default option for types to italic?

Done! I removed the O.styles.properties, not sure if keeping it makes much sense? Setting that to italic would obviously affect some other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants