Skip to content

Conversation

@cdcabrera
Copy link
Owner

What's included

  • refactor(build,parseApi): group funcs, memoize

Notes

  • prep for upcoming openapi, swagger integration

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Development cli check

  1. update the NPM packages with $ yarn
  2. $ yarn start:dev
  3. confirm that example responses come through for
    • success
    • error
    • random

Example

...

Updates issue/story

ongoing
#226

@cdcabrera cdcabrera added the enhancement New feature or request label Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #228 (8b93e38) into main (71d5fce) will increase coverage by 4.48%.
The diff coverage is 86.92%.

❗ Current head 8b93e38 differs from pull request most recent head cdc2f2c. Consider uploading reports for the commit cdc2f2c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   75.09%   79.57%   +4.48%     
==========================================
  Files           6        6              
  Lines         261      284      +23     
  Branches       81       96      +15     
==========================================
+ Hits          196      226      +30     
+ Misses         59       52       -7     
  Partials        6        6              
Impacted Files Coverage Δ
src/global.js 87.75% <77.77%> (-12.25%) ⬇️
src/api/parseApi.js 79.24% <86.66%> (+4.24%) ⬆️
src/api/buildApi.js 76.22% <89.77%> (+16.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d5fce...cdc2f2c. Read the comment docs.

* buildApi, group funcs, memoize responses
* parseApi, group related funcs, buildApi
* global, expand memo, async, expire
@cdcabrera cdcabrera force-pushed the 202303-swagger-partone branch from 8b93e38 to cdc2f2c Compare March 9, 2023 05:24
@cdcabrera cdcabrera merged commit 7fc30f9 into main Mar 9, 2023
@cdcabrera cdcabrera deleted the 202303-swagger-partone branch January 25, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants