fix: remove allowImportingTsExtensions support

Does not play well during a nested lookup when we're looking up a path that
we've already resolved to a candidate with a .ts extension earlier in the
process. Not a super useful feature anyway.

Author: sorccu

packages/cli/src/services/check-parser/__tests__/check-parser.spec.ts

@@ -174,6 +174,7 @@ describe('dependency-parser - parser()', () => {
     const parser = new Parser({
       supportedNpmModules: defaultNpmModules,
     })
+    expect.assertions(1)
     try {
       // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const { dependencies } = parser.parse(toAbsolutePath('entrypoint.js'))

packages/cli/src/services/check-parser/package-files/lookup.ts

@@ -3,29 +3,18 @@ import { CoreExtension, FileExtPath, tsCoreExtensionLookupOrder, TSExtension, ts
 
 type Options = {
   plainJs?: boolean
-  allowImportingTsExtensions?: boolean
 }
 
 export class LookupContext {
   #plainJs: boolean
-  #allowImportingTsExtensions: boolean
 
   constructor (options: Options) {
     this.#plainJs = options.plainJs ?? false
-    this.#allowImportingTsExtensions = options.allowImportingTsExtensions ?? false
   }
 
-  static forFilePath (filePath: string, options?: Options) {
+  static forFilePath (filePath: string) {
     return new LookupContext({
       plainJs: FileExtPath.fromFilePath(filePath).hasCoreExtension(),
-      allowImportingTsExtensions: options?.allowImportingTsExtensions,
-    })
-  }
-
-  switch (options: Options) {
-    return new LookupContext({
-      plainJs: options.plainJs ?? this.#plainJs,
-      allowImportingTsExtensions: options.allowImportingTsExtensions ?? this.#allowImportingTsExtensions,
     })
   }
 
@@ -45,11 +34,9 @@ export class LookupContext {
       return extensions.map(ext => extPath.replaceExt(ext))
     }
 
-    if (this.#allowImportingTsExtensions) {
-      if (extPath.hasTypeScriptExtension()) {
-        const extensions = tsExtensionLookupOrder[extPath.ext as TSExtension]
-        return extensions.map(ext => extPath.replaceExt(ext))
-      }
+    if (extPath.hasTypeScriptExtension()) {
+      const extensions = tsExtensionLookupOrder[extPath.ext as TSExtension]
+      return extensions.map(ext => extPath.replaceExt(ext))
     }
 
     return this.extlessTSLookupPaths(extPath)

packages/cli/src/services/check-parser/package-files/resolver.ts

@@ -204,9 +204,7 @@ export class PackageFilesResolver {
             return context.collectLookupPaths(filePath)
           })
           for (const candidatePath of candidatePaths) {
-            const mainSourceFile = this.cache.sourceFile(candidatePath, context.switch({
-              allowImportingTsExtensions: configJson.allowImportingTsExtensions,
-            }))
+            const mainSourceFile = this.cache.sourceFile(candidatePath, context)
             if (mainSourceFile === undefined) {
               continue
             }
@@ -245,11 +243,8 @@ export class PackageFilesResolver {
     const dirname = path.dirname(filePath)
 
     const { tsconfigJson, jsconfigJson } = this.loadPackageFiles(filePath)
-    const mainConfigJson = tsconfigJson ?? jsconfigJson
 
-    const context = LookupContext.forFilePath(filePath, {
-      allowImportingTsExtensions: mainConfigJson?.allowImportingTsExtensions,
-    })
+    const context = LookupContext.forFilePath(filePath)
 
     resolve:
     for (const importPath of dependencies) {
@@ -283,18 +278,14 @@ export class PackageFilesResolver {
           continue
         }
 
-        const configContext = context.switch({
-          allowImportingTsExtensions: configJson.allowImportingTsExtensions,
-        })
-
         const resolvedPaths = configJson.resolvePath(importPath)
         if (resolvedPaths.length > 0) {
           let found = false
           for (const { source, target } of resolvedPaths) {
             const relativePath = path.resolve(configJson.basePath, target.path)
-            const sourceFile = this.cache.sourceFile(relativePath, configContext)
+            const sourceFile = this.cache.sourceFile(relativePath, context)
             if (sourceFile !== undefined) {
-              const resolvedFiles = this.resolveSourceFile(sourceFile, configContext)
+              const resolvedFiles = this.resolveSourceFile(sourceFile, context)
               for (const resolvedFile of resolvedFiles) {
                 configJson.registerRelatedSourceFile(resolvedFile)
                 resolved.local.push({
@@ -329,9 +320,9 @@ export class PackageFilesResolver {
 
         if (configJson.baseUrl !== undefined) {
           const relativePath = path.resolve(configJson.basePath, configJson.baseUrl, importPath)
-          const sourceFile = this.cache.sourceFile(relativePath, configContext)
+          const sourceFile = this.cache.sourceFile(relativePath, context)
           if (sourceFile !== undefined) {
-            const resolvedFiles = this.resolveSourceFile(sourceFile, configContext)
+            const resolvedFiles = this.resolveSourceFile(sourceFile, context)
             let found = false
             for (const resolvedFile of resolvedFiles) {
               configJson.registerRelatedSourceFile(resolvedFile)

packages/cli/src/services/check-parser/package-files/tsconfig-json-file.ts

@@ -54,12 +54,6 @@ interface CompilerOptions {
    * @see https://www.typescriptlang.org/tsconfig/#composite
    */
   composite?: boolean
-
-  /**
-   * If true, TypeScript-specific extensions can be imported. Requires
-   * either `noEmit: true` or `emitDeclarationOnly: true`.
-   */
-  allowImportingTsExtensions?: boolean
 }
 
 export interface Schema {
@@ -77,7 +71,6 @@ export class TSConfigFile {
   moduleResolution: string
   baseUrl?: string
   pathResolver: PathResolver
-  allowImportingTsExtensions: boolean
 
   relatedSourceFiles: SourceFile[] = []
 
@@ -94,8 +87,6 @@ export class TSConfigFile {
     }
 
     this.pathResolver = PathResolver.createFromPaths(this.baseUrl ?? '.', jsonFile.data.compilerOptions?.paths ?? {})
-
-    this.allowImportingTsExtensions = jsonFile.data.compilerOptions?.allowImportingTsExtensions ?? false
   }
 
   public get meta () {