-
Notifications
You must be signed in to change notification settings - Fork 87
Implicit H-bond interaction and Protein Helper function #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuyuan871111
wants to merge
5
commits into
master
Choose a base branch
from
gsoc_implicit_hbond
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* protein_helper function * add test data, fix type hint * implcit hbond notebook update * lite cif parser, aa templates * update to fix comments on protein helper function * first version of the protein helper function * add comment and new explicit variable name * Update prolif/protein_helper.py Co-authored-by: Cédric Bouysset <[email protected]> * Update prolif/protein_helper.py Co-authored-by: Cédric Bouysset <[email protected]> * update with comments, differentiate from pdbinf * Move constants to constants, fix various issues * add test functions * add more test functions, fix type check * fix bugs: check the number of res heavy atms * add test functions and test data, add feature: using SMILES template in protein helper function * add more tests for protein helper * add more tests * add more tests * add more tests * fix not coverd lines * pass type check and update notebook * Update prolif/io/protein_helper.py Co-authored-by: Cédric Bouysset <[email protected]> * Update tests/test_io.py Co-authored-by: Cédric Bouysset <[email protected]> * Update tests/test_io.py Co-authored-by: Cédric Bouysset <[email protected]> * update test_io.py * inverse the role of protein helper function * update function for using SMILES template * fix tests to cover all lines * update benzamidine test file * Update tests/test_io.py use contextlib Co-authored-by: Cédric Bouysset <[email protected]> * Update tests/test_io.py Co-authored-by: Cédric Bouysset <[email protected]> * not sure why pytest.raises is not working with mark.parameterize * find bugs and all should be fixed * update data path and remove redundant files * update path in notebook * update implicitHbond data readme.md --------- Co-authored-by: Cédric Bouysset <[email protected]>
* implicit interactions draft * prolif/interactions/interactions.py fixed with comments * add hbond probability function * Update prolif/interactions/interactions.py Co-authored-by: Cédric Bouysset <[email protected]> * interactions update * Update prolif/interactions/interactions.py Co-authored-by: Cédric Bouysset <[email protected]> * Update prolif/interactions/interactions.py Co-authored-by: Cédric Bouysset <[email protected]> * update g and d in vina_hbond_potential * merge two notebooks to one * add atom angle checks * first version of implicit hbond calculation with geometry check and vina hbond potential * fix type hint, and include data for building * data restructure * fix path in notebook * add tests and update SMARTS * modify tests * increase test coverage * modified comments and refresh the online falling checks * tests with include_water and ignore_geometry_checks flags * add geometry test * add more tests to cover * prolif constant add HOH into resname converting map * fix lint and type hint * update test * Update prolif/interactions/interactions.py Co-authored-by: Cédric Bouysset <[email protected]> * fixed with code review * check non-water atom's geometry as well (in an interaction involving waters * update notebooks and docs * update notebooks * udpate tests and notebooks * update docs * update docs * update residue name for atoms in molecule * update tutorials, try to fix the link * update tutorials * udpate parameters, with code review * update test * implicit H-bond tutorials done * update tutorials * add version, move vina hbond potential g and b as parameters * adjust docs * add important note in protein helper function * Update prolif/io/protein_helper.py Co-authored-by: Cédric Bouysset <[email protected]> * move constants.py to io/constants.py, improve docs, change variables' names, remove vdwradii arguments in implicit H-bond * udpate docs * udpate docs * remove acceptor angles from the parameters --------- Co-authored-by: Cédric Bouysset <[email protected]> Co-authored-by: Cédric Bouysset <[email protected]>
Type-checking reportDifference in type-hints coverage: OverviewRemaining errors |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 95.10% 95.97% +0.87%
==========================================
Files 23 27 +4
Lines 1878 2287 +409
==========================================
+ Hits 1786 2195 +409
Misses 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e , e.g. RNA, DNA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new method for detecting hydrogen-bond (H-bond) interactions in ProLIF. Before this, calculating H-bond interactions with ProLIF required a complete topology, including both heavy atoms and explicit hydrogens (explicit H-bond method).
This new implicit H-bond method can help users more easily calculate the H-bond interactions for experimental and computational structures without additional protonation steps.