small fix to propfind #44
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding that when Nokogiri (v1.5.5) parses the request_document it returns the names of child nodes with the namespace prefix already removed. Specifically, with this request_document (from goodreader):
The returned names of the child nodes of
<D:prop>are just 'getlastmodified', 'getcontentlength' and 'resourcetype', and are therefore ignored when the following find_all operation tests for the prefix. Perhaps there are more complex cases where the prop node has other children? But in my case If I remove that test everything works very nicely, including folder sync.Thank you for the library: it has just saved me a lot of time when I needed it most.