Add wrapper div around options & afterOptionsComponent #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Heh, it seems something odd happened with rebasing. Just need to look at the power-select.hbs change (which is the div). |
Collaborator
|
@nickschot I realize this is super old, but could you please rebase and fix conflicts? |
nickschot
force-pushed
the
feature/options-wrapper-div
branch
from
f4660c6 to
ec4f002
Compare
Contributor
Author
Not sure what was up with my branch, was a bit weird. But since it's a one liner I've just started afresh master again. Should be fixed. edit: oh my comment from 2018 already said something weird was going on 😂 |
nickschot
force-pushed
the
feature/options-wrapper-div
branch
from
ec4f002 to
5a5aa29
Compare
nickschot
force-pushed
the
feature/options-wrapper-div
branch
from
5a5aa29 to
b494577
Compare
Collaborator
|
Thanks @nickschot! Is there any possibility this would break things for some people or not? I'm trying to help out maintaining things here, but I am not super familiar with the internals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cibernox this is the second feature request I made in Discord. This enables the following change: https://github.com/weddingshoppe/ember-model-select/pull/6/files#diff-6cd7a1538e5e1eb6201624d486136991 meaning the loading mask height is independent of any style changes that are made to the search component.