fix(rpcinfo): fix type conversion panic when chaining call FreezeRPCInfo twice (#1888)

Author: DMwangnima

pkg/rpcinfo/copy.go

@@ -16,6 +16,8 @@
 
 package rpcinfo
 
+import "github.com/cloudwego/kitex/pkg/kerrors"
+
 type plainRPCInfo struct {
 	// use anonymous structs to force objects to be read-only
 	from struct{ EndpointInfo }
@@ -82,17 +84,34 @@ func copyInvocation(i Invocation) Invocation {
 	if i == nil {
 		return nil
 	}
-	ink := i.(*invocation)
-	nink := &invocation{
-		packageName:   ink.PackageName(),
-		serviceName:   ink.ServiceName(),
-		methodName:    ink.MethodName(),
-		methodInfo:    ink.MethodInfo(),
-		streamingMode: ink.StreamingMode(),
-		seqID:         ink.SeqID(),
-		// ignore extra info to users
+	var nink *invocation
+	var bizErr kerrors.BizStatusErrorIface
+	// fast-path, calling function of struct directly
+	if ink, ok := i.(*invocation); ok {
+		nink = &invocation{
+			packageName:   ink.PackageName(),
+			serviceName:   ink.ServiceName(),
+			methodName:    ink.MethodName(),
+			methodInfo:    ink.MethodInfo(),
+			streamingMode: ink.StreamingMode(),
+			seqID:         ink.SeqID(),
+			// ignore extra info to users
+		}
+		bizErr = ink.BizStatusErr()
+	} else {
+		nink = &invocation{
+			packageName:   i.PackageName(),
+			serviceName:   i.ServiceName(),
+			methodName:    i.MethodName(),
+			methodInfo:    i.MethodInfo(),
+			streamingMode: i.StreamingMode(),
+			seqID:         i.SeqID(),
+			// ignore extra info to users
+		}
+		bizErr = i.BizStatusErr()
 	}
-	nink.SetBizStatusErr(ink.BizStatusErr())
+
+	nink.SetBizStatusErr(bizErr)
 	return nink
 }
 

pkg/rpcinfo/copy_test.go

@@ -43,13 +43,23 @@ func TestFreezeRPCInfo(t *testing.T) {
 	ctx2 := FreezeRPCInfo(ctx)
 	test.Assert(t, ctx2 != ctx)
 	ri2 := GetRPCInfo(ctx2)
-	test.Assert(t, ri2 != nil)
-	test.Assert(t, ri2 != ri)
-
-	test.Assert(t, AsTaggable(ri2.From()) == nil)
-	test.Assert(t, AsTaggable(ri2.To()) == nil)
-	test.Assert(t, AsMutableEndpointInfo(ri2.From()) == nil)
-	test.Assert(t, AsMutableEndpointInfo(ri2.To()) == nil)
-	test.Assert(t, AsMutableRPCConfig(ri2.Config()) == nil)
-	test.Assert(t, ri2.Stats() == nil)
+	checkFreezeRPCInfo(t, ri2, ri)
+
+	// call FreezeRPCInfo continuously should not cause a panic
+	ctx3 := FreezeRPCInfo(ctx2)
+	test.Assert(t, ctx3 != ctx2)
+	ri3 := GetRPCInfo(ctx3)
+	checkFreezeRPCInfo(t, ri3, ri2)
+}
+
+func checkFreezeRPCInfo(t *testing.T, ri, prevRI RPCInfo) {
+	test.Assert(t, ri != nil)
+	test.Assert(t, ri != prevRI)
+
+	test.Assert(t, AsTaggable(ri.From()) == nil)
+	test.Assert(t, AsTaggable(ri.To()) == nil)
+	test.Assert(t, AsMutableEndpointInfo(ri.From()) == nil)
+	test.Assert(t, AsMutableEndpointInfo(ri.To()) == nil)
+	test.Assert(t, AsMutableRPCConfig(ri.Config()) == nil)
+	test.Assert(t, ri.Stats() == nil)
 }