-
Notifications
You must be signed in to change notification settings - Fork 572
Add auto labeler workflow setting to enable for lang/vi #3464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: The Anh Nguyen <[email protected]>
|
/cc @seokho-son |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the changes are LGTM!
Question: Is it okay to use dev-vi as the base branch? If so, when will it be synced with main?
I see that you guys talked about how we use the localization branches, when'll we use |
|
In cncf/glossary, localization teams generally open PRs against the IMO: However, I find it a bit odd that GitHub Actions defines different workflows for each branch.
|
|
Usually, the correct target branch for this kind of PR is main (we apply the most important settings to the main branch first, and then update the dev-xx branches accordingly). For this case, please change the base branch of the feature branch in this PR. |
|
Wow, It looks like they were submitted at exactly the same time!! As Seokho‑son suggested, please use the main branch as the base branch :) |
|
I changed the base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. let me merge this pr. :)
Describe your changes
Add auto labeler workflow setting to enable for lang/vi
Related issue number or link (ex:
resolves #issue-number)Closes: #3463
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".