Skip to content

Conversation

@ntheanh201
Copy link
Collaborator

Describe your changes

Add auto labeler workflow setting to enable for lang/vi

Related issue number or link (ex: resolves #issue-number)

Closes: #3463

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 2dcc641
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6801c381f6e2cd00081bc7c7
😎 Deploy Preview https://deploy-preview-3464--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntheanh201 ntheanh201 changed the base branch from main to dev-vi April 18, 2025 03:11
@ntheanh201
Copy link
Collaborator Author

/cc @seokho-son

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes are LGTM!

Question: Is it okay to use dev-vi as the base branch? If so, when will it be synced with main?

@ntheanh201
Copy link
Collaborator Author

Thanks, the changes are LGTM!

Question: Is it okay to use dev-vi as the base branch? If so, when will it be synced with main?

I see that you guys talked about how we use the localization branches, when'll we use main instead of dev-{lang}?

@Okabe-Junya
Copy link
Collaborator

Okabe-Junya commented Apr 18, 2025

In cncf/glossary, localization teams generally open PRs against the dev-<lang> branch.
This remains the case even after the initial release.

IMO: However, I find it a bit odd that GitHub Actions defines different workflows for each branch.
It’s not a big deal for simple workflows like actions/labeler, but I’d like to sync with main and the other branches sooner rather than later.

@seokho-son

What do you think about this? In any case, the changes are LGTM, so shall we move forward with this PR and revisit the discussion afterward?

@seokho-son
Copy link
Collaborator

@ntheanh201 @Okabe-Junya

Usually, the correct target branch for this kind of PR is main (we apply the most important settings to the main branch first, and then update the dev-xx branches accordingly).
However, when setting up a new localization branch, the base can be adjusted as needed.

For this case, please change the base branch of the feature branch in this PR.
This is because we need to update the dev-vi branch soon after the CODEOWNERS file is updated. #3460

@Okabe-Junya
Copy link
Collaborator

Wow, It looks like they were submitted at exactly the same time!!

As Seokho‑son suggested, please use the main branch as the base branch :)

@ntheanh201 ntheanh201 changed the base branch from dev-vi to main April 18, 2025 04:23
@ntheanh201
Copy link
Collaborator Author

I changed the base branch to main

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let me merge this pr. :)

@seokho-son seokho-son merged commit a4b7d66 into cncf:main Apr 18, 2025
6 checks passed
@ntheanh201 ntheanh201 deleted the labbeler/vi branch April 18, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update auto labeler workflow setting to enable for lang/vi

3 participants