Skip to content

Commit d955881

Browse files
authored
Merge pull request #20 from codecat15/minor-fixes
adding public constructors
2 parents 0a67c50 + aa9d280 commit d955881

File tree

2 files changed

+17
-48
lines changed

2 files changed

+17
-48
lines changed

HttpUtility/HURequest.swift

Lines changed: 14 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -8,63 +8,32 @@
88

99
import Foundation
1010

11-
public protocol Request {
11+
protocol Request {
1212
var url: URL { get set }
13-
var method: HUHttpMethods {get set}
13+
var method: HUHttpMethods { get set }
1414
}
1515

1616
public struct HURequest : Request {
17-
public var url: URL
18-
public var method: HUHttpMethods
17+
var url: URL
18+
var method: HUHttpMethods
1919
var requestBody: Data? = nil
2020

21-
init(withUrl url: URL, forHttpMethod method: HUHttpMethods, requestBody: Data? = nil) {
21+
public init(withUrl url: URL, forHttpMethod method: HUHttpMethods, requestBody: Data? = nil) {
2222
self.url = url
2323
self.method = method
2424
self.requestBody = requestBody != nil ? requestBody : nil
2525
}
2626
}
2727

28-
// the HUMedia will be part of next release
2928
public struct HUMultiPartRequest : Request {
30-
public var url: URL
31-
public var method: HUHttpMethods
29+
30+
var url: URL
31+
var method: HUHttpMethods
3232
var request : Encodable
33-
//var media : [HUMedia]? = nil
34-
}
3533

36-
//public struct HUMedia
37-
//{
38-
// let fileName : String // the name of the file that you want to save on the server
39-
// let data: Data
40-
// let mimeType: String // mime type of the file image/jpeg or image/png etc
41-
// let parameterName : String // api parameter name
42-
//
43-
// init(withMediaData data: Data, name: String, mimeType: HUMimeType, parameterName: String) {
44-
//
45-
// self.data = data
46-
// self.fileName = name
47-
// self.mimeType = mimeType.rawValue
48-
// self.parameterName = parameterName
49-
// }
50-
//}
51-
//
52-
//public enum HUMimeType : String
53-
//{
54-
// // images mime type
55-
// case gif = "image/gif"
56-
// case jpeg = "image/jpeg"
57-
// case pjpeg = "image/pjpeg"
58-
// case png = "image/png"
59-
// case svgxml = "image/svg+xml"
60-
// case tiff = "image/tiff"
61-
// case bmp = "image/bmp"
62-
//
63-
// // document mime type
64-
// case csv = "text/csv"
65-
// case wordDocument = "application/msword"
66-
// case pdf = "application/pdf"
67-
// case richTextFormat = "application/rtf"
68-
// case plainText = "text/plain"
69-
//
70-
//}
34+
public init(withUrl url: URL, forHttpMethod method: HUHttpMethods, requestBody: Encodable) {
35+
self.url = url
36+
self.method = method
37+
self.request = requestBody
38+
}
39+
}

HttpUtilityTests/IntegrationTests/HttpUtilityIntegrationTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class HttpUtilityIntegrationTests: XCTestCase {
167167
let requestUrl = URL(string: "https://api-dev-scus-demo.azurewebsites.net/TestMultiPart")
168168

169169
let myStruct = MultiPartPostRequest(name: "Bruce", lastName: "Wayne")
170-
let multiPartRequest = HUMultiPartRequest(url: requestUrl!, method: .post, request: myStruct)
170+
let multiPartRequest = HUMultiPartRequest(withUrl: requestUrl!, forHttpMethod: .post, requestBody: myStruct)
171171

172172
// ACT
173173
_utility.requestWithMultiPartFormData(multiPartRequest: multiPartRequest, responseType: TestMultiPartResponse.self) { (response) in
@@ -198,7 +198,7 @@ class HttpUtilityIntegrationTests: XCTestCase {
198198

199199
let multiPartFormRequest = MultiPartFormRequest(name: "Bruce", lastName: "Wayne", gender: "Male", departmentName: "Tech", managerName: "James Gordan", dateOfJoining: "01-09-2020", dateOfBirth: "07-07-1988")
200200

201-
let multiPartRequest = HUMultiPartRequest(url: requestUrl!, method: .post, request: multiPartFormRequest)
201+
let multiPartRequest = HUMultiPartRequest(withUrl: requestUrl!, forHttpMethod: .post, requestBody: multiPartFormRequest)
202202

203203
// ACT
204204
_utility.requestWithMultiPartFormData(multiPartRequest: multiPartRequest, responseType: MultiPartResponse.self) { (response) in
@@ -230,7 +230,7 @@ class HttpUtilityIntegrationTests: XCTestCase {
230230

231231
let fileUploadRequest = MultiPartFormFileUploadRequest(attachment: imageData!, fileName: "utilityTest")
232232

233-
let multiPartRequest = HUMultiPartRequest(url: requestUrl!, method: .post, request: fileUploadRequest)
233+
let multiPartRequest = HUMultiPartRequest(withUrl: requestUrl!, forHttpMethod: .post, requestBody: fileUploadRequest)
234234

235235
// ACT
236236
_utility.requestWithMultiPartFormData(multiPartRequest: multiPartRequest, responseType: MultiPartImageUploadResponse.self) { (response) in

0 commit comments

Comments
 (0)