CommentThread#remove_follower should remove all followers

Author: Oaphi

.rubocop.yml

@@ -58,7 +58,7 @@ Naming/BlockForwarding:
   EnforcedStyle: explicit
 Naming/PredicateMethod:
   Mode: conservative
-  AllowedPatterns: ['verify_.*', 'check_.*', 'enforce_.*', 'setup_.*']
+  AllowedPatterns: ['verify_.*', 'check_.*', 'enforce_.*', 'setup_.*','add_.*', 'remove_.*']
   AllowedMethods:
     - post_sign_in # returns a boolean but is a necessary after-sign-in method for both normal and SAML flows
     - comment_rate_limited? # returns a tuple with the boolean as the first value

app/models/comment_thread.rb

@@ -109,7 +109,7 @@ def bump_last_activity(persist_changes: false)
   # @param user [User] user to remove from followers
   # @return [Boolean] status of the operation
   def remove_follower(user)
-    ThreadFollower.find_by(comment_thread: self, user: user)&.destroy || false
+    ThreadFollower.where(comment_thread: self, user: user).destroy_all.any?
   end
 
   private