Skip to content

Conversation

@AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Nov 22, 2025

Summary

Changes to recipe: curl/1.13.0

Motivation

Version bump

Details


  • Read the contributing guidelines
  • Checked that this PR is not a duplicate: list of PRs by recipe
  • If this is a bug fix, please link related issue or provide bug details
  • Tested locally with at least one configuration using a recent version of Conan

Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!

@ErniGH
Copy link
Contributor

ErniGH commented Nov 24, 2025

The new version adds the option CPR_CURL_USE_LIBPSL, and it assumes that libcurl will use libpsl by default. The recipe of libcurl in conancenter uses with_libpsl=False by default. I think we should change this new option in order to disable it by default.

I tested both options locally, and it works for me, but I think this option can be a risk in the future

new option: libcpr/cpr@1.12.0...1.13.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR60
libcurl: https://github.com/conan-io/conan-center-index/blob/master/recipes/libcurl/all/conanfile.py#L102

@ErniGH ErniGH changed the title add curl/1.13.0 add cpr/1.13.0 Nov 24, 2025
@AndreyMlashkin
Copy link
Contributor Author

The new version adds the option CPR_CURL_USE_LIBPSL, and it assumes that libcurl will use libpsl by default. The recipe of libcurl in conancenter uses with_libpsl=False by default. I think we should change this new option in order to disable it by default.

I tested both options locally, and it works for me, but I think this option can be a risk in the future

new option: libcpr/[email protected]#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR60 libcurl: https://github.com/conan-io/conan-center-index/blob/master/recipes/libcurl/all/conanfile.py#L102

Thank you for your review!
I am now following the curl flag for libpsl, please take a look

I have tested a package creation:
conan create . --version=1.13.0 --build=missing -o "libcurl/*:with_libpsl=True"

But I have limited knowledge about the underlying functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants