Skip to content

avoid import to testing pkg outside of tests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

avoid import to testing pkg outside of tests #128

wants to merge 1 commit into from

Conversation

@tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Apr 8, 2025

Go deadcode removal is not very smart, especially if other code that imports this pkg uses reflect.

@tonistiigi tonistiigi mentioned this pull request Apr 8, 2025
Merged
@cpuguy83
Copy link
Member

cpuguy83 commented Jul 1, 2025

Looks like a go mod update is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonistiigi @cpuguy83