checkpoint: unexport subcommand

unexport subcommand

Signed-off-by: ChengyuZhu6 <[email protected]>

Author: ChengyuZhu6

cmd/nerdctl/checkpoint/checkpoint.go

@@ -33,22 +33,22 @@ func Command() *cobra.Command {
 	}
 
 	cmd.AddCommand(
-		CreateCommand(),
-		checkpointLsCommand(),
-		checkpointRmCommand(),
+		createCommand(),
+		lsCommand(),
+		rmCommand(),
 	)
 
 	return cmd
 }
 
-func checkpointLsCommand() *cobra.Command {
-	x := ListCommand()
+func lsCommand() *cobra.Command {
+	x := listCommand()
 	x.Use = "ls"
 	x.Aliases = []string{"list"}
 	return x
 }
-func checkpointRmCommand() *cobra.Command {
-	x := RemoveCommand()
+func rmCommand() *cobra.Command {
+	x := removeCommand()
 	x.Use = "rm"
 	x.Aliases = []string{"remove"}
 	return x

cmd/nerdctl/checkpoint/checkpoint_create.go

@@ -28,7 +28,7 @@ import (
 	"github.com/containerd/nerdctl/v2/pkg/cmd/checkpoint"
 )
 
-func CreateCommand() *cobra.Command {
+func createCommand() *cobra.Command {
 	var cmd = &cobra.Command{
 		Use:               "create [OPTIONS] CONTAINER CHECKPOINT",
 		Short:             "Create a checkpoint from a running container",

cmd/nerdctl/checkpoint/checkpoint_create_linux_test.go

@@ -83,6 +83,7 @@ func TestCheckpointCreate(t *testing.T) {
 		// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
 		require.Not(nerdtest.Docker),
 	)
+	testCase.NoParallel = true
 	testCase.SubTests = []*test.Case{
 		{
 			Description: "leave-running=true",

cmd/nerdctl/checkpoint/checkpoint_list.go

@@ -29,7 +29,7 @@ import (
 	"github.com/containerd/nerdctl/v2/pkg/cmd/checkpoint"
 )
 
-func ListCommand() *cobra.Command {
+func listCommand() *cobra.Command {
 	var cmd = &cobra.Command{
 		Use:               "list [OPTIONS] CONTAINER",
 		Short:             "List checkpoints for a container",

cmd/nerdctl/checkpoint/checkpoint_list_linux_test.go

@@ -80,15 +80,14 @@ func TestCheckpointList(t *testing.T) {
 		// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
 		require.Not(nerdtest.Docker),
 	)
-
+	testCase.NoParallel = true
 	testCase.Setup = func(data test.Data, helpers test.Helpers) {
 		helpers.Ensure("run", "-d", "--name", data.Identifier(), testutil.CommonImage, "sleep", "infinity")
 		helpers.Ensure("checkpoint", "create", data.Identifier(), checkpointName)
 	}
 
 	testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
 		helpers.Anyhow("rm", "-f", data.Identifier())
-		helpers.Anyhow("rmi", "-f", testutil.CommonImage)
 	}
 
 	testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {

cmd/nerdctl/checkpoint/checkpoint_remove.go

@@ -28,7 +28,7 @@ import (
 	"github.com/containerd/nerdctl/v2/pkg/cmd/checkpoint"
 )
 
-func RemoveCommand() *cobra.Command {
+func removeCommand() *cobra.Command {
 	var cmd = &cobra.Command{
 		Use:               "rm [OPTIONS] CONTAINER CHECKPOINT",
 		Short:             "Remove a checkpoint",

cmd/nerdctl/checkpoint/checkpoint_remove_linux_test.go

@@ -83,6 +83,7 @@ func TestCheckpointRemove(t *testing.T) {
 		// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
 		require.Not(nerdtest.Docker),
 	)
+	testCase.NoParallel = true
 	testCase.SubTests = []*test.Case{
 		{
 			Description: "remove-existing",
@@ -92,7 +93,6 @@ func TestCheckpointRemove(t *testing.T) {
 			},
 			Cleanup: func(data test.Data, helpers test.Helpers) {
 				helpers.Anyhow("rm", "-f", data.Identifier("container-running-remove"))
-				helpers.Anyhow("rmi", "-f", testutil.CommonImage)
 			},
 			Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
 				return helpers.Command("checkpoint", "rm", "--checkpoint-dir", checkpointDir, data.Identifier("container-running-remove"), checkpointName)
@@ -111,7 +111,6 @@ func TestCheckpointRemove(t *testing.T) {
 			},
 			Cleanup: func(data test.Data, helpers test.Helpers) {
 				helpers.Anyhow("rm", "-f", data.Identifier("container-clean-remove"))
-				helpers.Anyhow("rmi", "-f", testutil.CommonImage)
 			},
 			Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
 				return helpers.Command("checkpoint", "rm", "--checkpoint-dir", checkpointDir, data.Identifier("container-clean-remove"), checkpointName)