Use functions inside the installation script to make the installation more reliable

[sneak]

Error Message and Logs

The recommended install method:

curl -fsSL https://cdn.coollabs.io/coolify/install.sh | sudo bash

Downloads the install.sh script and executes it. But, if the download fails part of the way through, it may truncate a command and cause unexpected behavior, for example, the command systemctl start sshd in install.sh could instead run systemctl start ss if the script gets truncated there, causing unwanted behavior (and it's run as root!). rm -rf /path/to/file can become rm -rf /.

The solution to this is to wrap all of the logic in the script in a function, then call it at the bottom, ensuring the whole script has loaded. I usually use the function name "main" for this purpose, e.g.:

function main () {
    echo "hello world"
    # install stuff
}

main

Additionally, this sort of paves the way to further modularize the installation into functions grouping sections of commands (e.g. installDocker, checkSSH, etc) which can then be called from main, e.g.:

function createDirectories () {
    mkdir -p /data/coolify/{source,ssh,applications,databases,backups,services,proxy,webhooks-during-maintenance,sentinel}
    mkdir -p /data/coolify/ssh/{keys,mux}
    mkdir -p /data/coolify/proxy/dynamic

    chown -R 9999:root /data/coolify
    chmod -R 700 /data/coolify
}

function main () {
     setupEnvironment
     warnIfDiskSpaceLow
    createDirectories
    ....
    getAJoke
}

main

This was actually the inspiration for this, as the install script is approaching 900 lines of commands aligned with the far left margin, making one have to read the entire thing line by line to get a high-level overview of the code. I was hoping such a large script would be broken into sections/functions.

Steps to Reproduce

1. run recommended install command
2. unplug network cable at just the right moment

Example Repository URL

No response

Coolify Version

main

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

na

Additional Information

No response