Adding parser for Xfunctions in Rule validation #7111
Conversation
dosubot
bot
added
the
component/rules
PaurushGarg
force-pushed
the
parser-xfunctions-ruler
branch
from
23387d9 to
ea89998
Compare
Signed-off-by: Paurush Garg <[email protected]>
PaurushGarg
force-pushed
the
parser-xfunctions-ruler
branch
from
ea89998 to
23d5cf9
Compare
Signed-off-by: Paurush Garg <[email protected]>
There was a problem hiding this comment.
We should try to reuse the same manager_test.go file instead of creating a new file for this
There was a problem hiding this comment.
thanks. updated.
| } | ||
| } | ||
|
|
||
| func TestValidateRuleGroup_AcceptsStandardFunctions(t *testing.T) { |
There was a problem hiding this comment.
Can we add a test case that this validation function successfully failed an invalid rule group for some other issues? I want to make sure that the error is propagated correctly
There was a problem hiding this comment.
Thanks. I have updated to bugfix.
PaurushGarg
changed the title
Signed-off-by: Paurush Garg <[email protected]>
CHANGELOG.md
Outdated
| * [ENHANCEMENT] Distributor: Add a label references validation for remote write v2 request. #7074 | ||
| * [ENHANCEMENT] Distributor: Add count, spans, and buckets validations for native histogram. #7072 | ||
| * [BUGFIX] Ring: Change DynamoDB KV to retry indefinitely for WatchKey. #7088 | ||
| * [FEATURE] Ruler: Add XFunctions validation support. #7111 |
There was a problem hiding this comment.
Could you move change log?
The changelog order is:
* `[CHANGE]`
* `[FEATURE]`
* `[ENHANCEMENT]`
* `[BUGFIX]`
There was a problem hiding this comment.
I would call it a bugfix instead of a feature. Ruler xfunction support was added in last release but it doesn't work because of this failure
There was a problem hiding this comment.
Yeah, it seems a bug rather than feature.
There was a problem hiding this comment.
Thanks. I have updated to bugfix.
Signed-off-by: Paurush Garg <[email protected]>
4 participants
What this PR does:
Xfunction parsing support in rules validation.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]