Update Safe url

[harisang]

This PR updates the Safe url that is printed as part of the msg on slack as current one doesn't seem to be working anymore

Current one: https://app.safe.global/eth:0xA03be496e67Ec29bC62F01a428683D7F9c204930/transactions/queue

Correct: https://app.safe.global/transactions/queue?safe=eth:0xA03be496e67Ec29bC62F01a428683D7F9c204930

[bram-vdberg]

Do we have the safe tx hash for the transaction? If so we could update the url to link directly to the transaction instead of the queue.

For exmple:
https://app.safe.global/transactions/tx?safe=bnb:0xA03be496e67Ec29bC62F01a428683D7F9c204930&id=multisig_0xA03be496e67Ec29bC62F01a428683D7F9c204930_0xbab9c9b2e173fd469b4e9184971fdc9568b8095eee9ac156c840a4ce4953865c

The url seems to contain the safe address twice and the tx's safe transaction hash at the end.

[harisang]

Do we have the safe tx hash for the transaction? If so we could update the url to link directly to the transaction instead of the queue.

For exmple: https://app.safe.global/transactions/tx?safe=bnb:0xA03be496e67Ec29bC62F01a428683D7F9c204930&id=multisig_0xA03be496e67Ec29bC62F01a428683D7F9c204930_0xbab9c9b2e173fd469b4e9184971fdc9568b8095eee9ac156c840a4ce4953865c

The url seems to contain the safe address twice and the tx's safe transaction hash at the end.

The tx hash can be found within the post_multisend() call (see here for example). So one would probably need to modify what the post_multisend() returns, so that it returns, for example, the nonce and the tx hash.

I admit i don't have time to do the change now. Feel free to execute on this (or any other solution you think is more appropriate) here

[fhenneke]

(Haris was faster)
We do print the hash here:

solver-rewards/src/multisend.py

Line 124 in 5b321db

f" {safe_tx.safe_tx_hash.hex()} to {safe.address}"

So in principle we have all required information for a direct link to the transaction. The info is not available currently at the right place in the code.

There is also an advantage of having a non-specific link. Even manually going to app.safe.global and to the wallet could work as that might reduce the risk of fishing attacks. (Or reduce complacent behavior with respect to links.)

None of that is required for now I think.

[harisang]

I would say let's merge as is to keep things simpler