test: Add tests on auto id generation #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surister
force-pushed
the
fix/id_tests
branch
from
005f338 to
3f4c4ab
Compare
amotl
approved these changes
Nov 9, 2025
| ) | ||
| assert ( | ||
| sql | ||
| == "INTEGER GENERATED ALWAYS AS CAST((random() * 1.0E9) AS integer) NOT NULL PRIMARY KEY" |
Member
There was a problem hiding this comment.
Just curious: Is the library using random numbers to auto-generate primary key values?
Member
Author
There was a problem hiding this comment.
Django expects auto generated fields to be integers, we do not have auto-incremental integers.
So we cannot use gen_random_text_uuid. If they are not integers things fall apart in many places, we could also use current timestamp but I don't want to deal right now with timestamp generation collision or any of the kind, so I chose to just generate a random number as a pk.
Member
Author
There was a problem hiding this comment.
The ideal solution is that they improve auto fields to let us choose which datatype it is (it's on the works), then we can just use TEXT and gen_random_text_uuid
surister
force-pushed
the
fix/id_tests
branch
from
3f4c4ab to
be017b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
This just adds new tests on id generation.
Checklist