Support CREATE EXTENSION ... CASCADE (#108)

Author: kostiantyn-nemchenko

postgresql/resource_postgresql_extension.go

@@ -13,11 +13,12 @@ import (
 )
 
 const (
-	extNameAttr        = "name"
-	extSchemaAttr      = "schema"
-	extVersionAttr     = "version"
-	extDatabaseAttr    = "database"
-	extDropCascadeAttr = "drop_cascade"
+	extNameAttr          = "name"
+	extSchemaAttr        = "schema"
+	extVersionAttr       = "version"
+	extDatabaseAttr      = "database"
+	extDropCascadeAttr   = "drop_cascade"
+	extCreateCascadeAttr = "create_cascade"
 )
 
 func resourcePostgreSQLExtension() *schema.Resource {
@@ -62,6 +63,12 @@ func resourcePostgreSQLExtension() *schema.Resource {
 				Default:     false,
 				Description: "When true, will also drop all the objects that depend on the extension, and in turn all objects that depend on those objects",
 			},
+			extCreateCascadeAttr: {
+				Type:        schema.TypeBool,
+				Optional:    true,
+				Default:     false,
+				Description: "When true, will also create any extensions that this extension depends on that are not already installed",
+			},
 		},
 	}
 }
@@ -88,6 +95,10 @@ func resourcePostgreSQLExtensionCreate(db *DBConnection, d *schema.ResourceData)
 		fmt.Fprint(b, " VERSION ", pq.QuoteIdentifier(v.(string)))
 	}
 
+	if d.Get(extCreateCascadeAttr).(bool) {
+		fmt.Fprint(b, " CASCADE")
+	}
+
 	txn, err := startTransaction(db.client, databaseName)
 	if err != nil {
 		return err

postgresql/resource_postgresql_extension_test.go

@@ -258,6 +258,59 @@ func testAccCreateExtensionDependency(tableName string) resource.TestCheckFunc {
 	}
 }
 
+func TestAccPostgresqlExtension_CreateCascade(t *testing.T) {
+	skipIfNotAcc(t)
+
+	var testAccPostgresqlExtensionConfig = `
+resource "postgresql_extension" "cascade" {
+  name = "earthdistance"
+  create_cascade = true
+}
+`
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheck(t)
+			testCheckCompatibleVersion(t, featureExtension)
+			testSuperuserPreCheck(t)
+		},
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckPostgresqlExtensionDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccPostgresqlExtensionConfig,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckPostgresqlExtensionExists("postgresql_extension.cascade"),
+					resource.TestCheckResourceAttr("postgresql_extension.cascade", "name", "earthdistance"),
+					// The cube extension should be installed as a dependency of earthdistance.
+					testAccCheckExtensionDependency("cube"),
+				),
+			},
+		},
+	})
+}
+
+func testAccCheckExtensionDependency(extName string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+
+		client := testAccProvider.Meta().(*Client)
+		txn, err := startTransaction(client, client.databaseName)
+		if err != nil {
+			return err
+		}
+		defer deferredRollback(txn)
+
+		exists, err := checkExtensionExists(txn, extName)
+		if err != nil {
+			return fmt.Errorf("Error checking extension %s", err)
+		}
+		if !exists {
+			return fmt.Errorf("Extension %s not found", extName)
+		}
+
+		return nil
+	}
+}
+
 var testAccPostgresqlExtensionConfig = `
 resource "postgresql_extension" "myextension" {
   name = "pg_trgm"

website/docs/r/postgresql_extension.html.markdown

@@ -27,3 +27,4 @@ resource "postgresql_extension" "my_extension" {
 * `version` - (Optional) Sets the version number of the extension.
 * `database` - (Optional) Which database to create the extension on. Defaults to provider database.
 * `drop_cascade` - (Optional) When true, will also drop all the objects that depend on the extension, and in turn all objects that depend on those objects. (Default: false)
+* `create_cascade` - (Optional) When true, will also create any extensions that this extension depends on that are not already installed. (Default: false)