add 'additionalProperties: false' to most schemas (#321)

Author: jakemac53

pkgs/dart_mcp_server/CHANGELOG.md

@@ -8,6 +8,8 @@
   instead of DTD URI.
 - Add a tool for reading package: URIs. Results are returned as embedded
   resources or resource links (when reading a directory).
+- Add `additionalProperties: false` to most schemas so they provide better
+  errors when invoked with incorrect arguments.
 
 # 0.1.1 (Dart SDK 3.10.0)
 

pkgs/dart_mcp_server/lib/src/mixins/analyzer.dart

@@ -464,6 +464,7 @@ base mixin DartAnalyzerSupport
     description: 'Analyzes specific paths, or the entire project, for errors.',
     inputSchema: Schema.object(
       properties: {ParameterNames.roots: rootsSchema(supportsPaths: true)},
+      additionalProperties: false,
     ),
     annotations: ToolAnnotations(title: 'Analyze projects', readOnlyHint: true),
   );
@@ -489,6 +490,7 @@ base mixin DartAnalyzerSupport
           'and locations. Be sure to check the name of the responses to ensure '
           'it looks like the thing you were searching for.',
       required: [ParameterNames.query],
+      additionalProperties: false,
     ),
     annotations: ToolAnnotations(title: 'Project search', readOnlyHint: true),
   );
@@ -542,6 +544,7 @@ final _locationSchema = Schema.object(
     ),
   },
   required: [ParameterNames.uri, ParameterNames.line, ParameterNames.column],
+  additionalProperties: false,
 );
 
 extension on Root {

pkgs/dart_mcp_server/lib/src/mixins/dash_cli.dart

@@ -184,6 +184,7 @@ base mixin DashCliSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport
     annotations: ToolAnnotations(title: 'Dart fix', destructiveHint: true),
     inputSchema: Schema.object(
       properties: {ParameterNames.roots: rootsSchema()},
+      additionalProperties: false,
     ),
   );
 
@@ -193,6 +194,7 @@ base mixin DashCliSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport
     annotations: ToolAnnotations(title: 'Dart format', destructiveHint: true),
     inputSchema: Schema.object(
       properties: {ParameterNames.roots: rootsSchema(supportsPaths: true)},
+      additionalProperties: false,
     ),
   );
 
@@ -213,6 +215,7 @@ base mixin DashCliSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport
           ParameterNames.roots: rootsSchema(supportsPaths: true),
           ParameterNames.testRunnerArgs: cliSchema,
         },
+        additionalProperties: false,
       ),
     );
   }();
@@ -258,6 +261,7 @@ base mixin DashCliSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport
         ParameterNames.projectType,
         ParameterNames.root,
       ],
+      additionalProperties: false,
     ),
   );
 

pkgs/dart_mcp_server/lib/src/mixins/dtd.dart

@@ -921,6 +921,7 @@ base mixin DartToolingDaemonSupport
     inputSchema: Schema.object(
       properties: {ParameterNames.uri: Schema.string()},
       required: const [ParameterNames.uri],
+      additionalProperties: false,
     ),
   );
 
@@ -944,6 +945,7 @@ base mixin DartToolingDaemonSupport
               'relevant before reading them again.',
         ),
       },
+      additionalProperties: false,
     ),
   );
 
@@ -955,7 +957,7 @@ base mixin DartToolingDaemonSupport
         'current state. Requires "${connectTool.name}" to be successfully '
         'called first.',
     annotations: ToolAnnotations(title: 'Take screenshot', readOnlyHint: true),
-    inputSchema: Schema.object(),
+    inputSchema: Schema.object(additionalProperties: false),
   );
 
   @visibleForTesting
@@ -977,7 +979,7 @@ base mixin DartToolingDaemonSupport
               'relevant.',
         ),
       },
-      required: [],
+      additionalProperties: false,
     ),
   );
 
@@ -992,7 +994,7 @@ base mixin DartToolingDaemonSupport
         "successfully called first. Doesn't work for Non-Flutter Dart CLI "
         'programs.',
     annotations: ToolAnnotations(title: 'Hot restart', destructiveHint: true),
-    inputSchema: Schema.object(properties: {}, required: []),
+    inputSchema: Schema.object(additionalProperties: false),
   );
 
   @visibleForTesting
@@ -1010,6 +1012,7 @@ base mixin DartToolingDaemonSupport
               'are returned.',
         ),
       },
+      additionalProperties: false,
     ),
   );
 
@@ -1023,7 +1026,7 @@ base mixin DartToolingDaemonSupport
       title: 'Get selected widget',
       readOnlyHint: true,
     ),
-    inputSchema: Schema.object(),
+    inputSchema: Schema.object(additionalProperties: false),
   );
 
   @visibleForTesting
@@ -1043,6 +1046,7 @@ base mixin DartToolingDaemonSupport
         'enabled': Schema.bool(title: 'Enable widget selection mode'),
       },
       required: const ['enabled'],
+      additionalProperties: false,
     ),
   );
 
@@ -1057,7 +1061,7 @@ base mixin DartToolingDaemonSupport
       title: 'Get Active Editor Location',
       readOnlyHint: true,
     ),
-    inputSchema: Schema.object(),
+    inputSchema: Schema.object(additionalProperties: false),
   );
 
   static final _connectedAppsNotSupported = CallToolResult(

pkgs/dart_mcp_server/lib/src/mixins/flutter_launcher.dart

@@ -69,6 +69,7 @@ base mixin FlutterLauncherSupport
         ),
       },
       required: ['root', 'device'],
+      additionalProperties: false,
     ),
     outputSchema: Schema.object(
       properties: {
@@ -255,6 +256,7 @@ base mixin FlutterLauncherSupport
         ),
       },
       required: ['pid'],
+      additionalProperties: false,
     ),
     outputSchema: Schema.object(
       properties: {
@@ -325,6 +327,7 @@ base mixin FlutterLauncherSupport
         ),
       },
       required: ['devices'],
+      additionalProperties: false,
     ),
   );
 
@@ -410,6 +413,7 @@ base mixin FlutterLauncherSupport
         ),
       },
       required: ['pid'],
+      additionalProperties: false,
     ),
     outputSchema: Schema.object(
       properties: {
@@ -487,6 +491,7 @@ base mixin FlutterLauncherSupport
         ),
       },
       required: ['apps'],
+      additionalProperties: false,
     ),
   );
 

pkgs/dart_mcp_server/lib/src/mixins/package_uri_reader.dart

@@ -199,6 +199,7 @@ base mixin PackageUriSupport on ToolsSupport, RootsTrackingSupport
         ParameterNames.root: rootSchema,
       },
       required: [ParameterNames.uris, ParameterNames.root],
+      additionalProperties: false,
     ),
   );
 }

pkgs/dart_mcp_server/lib/src/mixins/pub.dart

@@ -103,6 +103,7 @@ base mixin PubSupport on ToolsSupport, LoggingSupport, RootsTrackingSupport
         ParameterNames.roots: rootsSchema(),
       },
       required: [ParameterNames.command],
+      additionalProperties: false,
     ),
   );
 }

pkgs/dart_mcp_server/lib/src/mixins/pub_dev_search.dart

@@ -217,6 +217,7 @@ To search for alternatives do multiple searches. There is no "or" operator.
         ),
       },
       required: ['query'],
+      additionalProperties: false,
     ),
   );
 }

pkgs/dart_mcp_server/lib/src/mixins/roots_fallback_support.dart

@@ -147,6 +147,7 @@ base mixin RootsFallbackSupport on ToolsSupport, RootsTrackingSupport {
           ),
         ),
       },
+      additionalProperties: false,
     ),
   );
 
@@ -164,6 +165,7 @@ base mixin RootsFallbackSupport on ToolsSupport, RootsTrackingSupport {
           items: Schema.string(description: 'The URIs of the roots to remove.'),
         ),
       },
+      additionalProperties: false,
     ),
   );
 }

pkgs/dart_mcp_server/test/tools/pub_dev_search_test.dart

@@ -33,7 +33,7 @@ void main() {
       await runWithHarness((testHarness, pubDevSearchTool) async {
         final request = CallToolRequest(
           name: pubDevSearchTool.name,
-          arguments: {'query': 'retry', 'latestVersion': '3.1.2'},
+          arguments: {'query': 'retry'},
         );
 
         final result = await testHarness.callToolWithRetry(