code review updates

Author: jakemac53

pkgs/dart_mcp_server/lib/src/mixins/dtd.dart

@@ -134,7 +134,7 @@ base mixin DartToolingDaemonSupport
                 serverVersion: implementation.version,
                 type: AnalyticsEvent.readResource.name,
                 additionalData: ReadResourceMetrics(
-                  kind: 'runtimeErrors',
+                  kind: ResourceKind.runtimeErrors,
                   length: result.contents.length,
                   elapsedMilliseconds: watch.elapsedMilliseconds,
                 ),

pkgs/dart_mcp_server/lib/src/utils/analytics.dart

@@ -15,11 +15,12 @@ abstract interface class AnalyticsSupport {
 
 enum AnalyticsEvent { callTool, readResource }
 
+/// The metrics for a resources/read MCP handler.
 final class ReadResourceMetrics extends CustomMetrics {
   /// The kind of resource that was read.
   ///
   /// We don't want to record the full URI.
-  final String kind;
+  final ResourceKind kind;
 
   /// The length of the resource.
   final int length;
@@ -35,12 +36,13 @@ final class ReadResourceMetrics extends CustomMetrics {
 
   @override
   Map<String, Object> toMap() => {
-    'kind': 'runtimeErrors',
-    'length': length,
-    'elapsedMilliseconds': elapsedMilliseconds,
+    _kind: kind.name,
+    _length: length,
+    _elapsedMilliseconds: elapsedMilliseconds,
   };
 }
 
+/// The metrics for a tools/call MCP handler.
 final class CallToolMetrics extends CustomMetrics {
   /// The name of the tool that was invoked.
   final String tool;
@@ -59,8 +61,16 @@ final class CallToolMetrics extends CustomMetrics {
 
   @override
   Map<String, Object> toMap() => {
-    'tool': tool,
-    'success': success,
-    'elapsedMilliseconds': elapsedMilliseconds,
+    _tool: tool,
+    _success: success,
+    _elapsedMilliseconds: elapsedMilliseconds,
   };
 }
+
+enum ResourceKind { runtimeErrors }
+
+const _elapsedMilliseconds = 'elapsedMilliseconds';
+const _kind = 'kind';
+const _length = 'length';
+const _success = 'success';
+const _tool = 'tool';

pkgs/dart_mcp_server/test/tools/dtd_test.dart

@@ -10,6 +10,7 @@ import 'package:async/async.dart';
 import 'package:dart_mcp/server.dart';
 import 'package:dart_mcp_server/src/mixins/dtd.dart';
 import 'package:dart_mcp_server/src/server.dart';
+import 'package:dart_mcp_server/src/utils/analytics.dart';
 import 'package:dart_mcp_server/src/utils/constants.dart';
 import 'package:test/test.dart';
 import 'package:unified_analytics/testing.dart';
@@ -505,7 +506,7 @@ void main() {
                         'clientVersion': server.clientInfo.version,
                         'serverVersion': server.implementation.version,
                         'type': 'readResource',
-                        'kind': 'runtimeErrors',
+                        'kind': ResourceKind.runtimeErrors.name,
                         'length': isA<int>(),
                         'elapsedMilliseconds': isA<int>(),
                       }),