fixed clippy warnings

Author: ZocoLini

dash-spv/src/chain/chainlock_manager.rs

@@ -178,7 +178,7 @@ impl ChainLockManager {
         if let Some(header) = storage
             .get_header(chain_lock.block_height)
             .await
-            .map_err(|e| ValidationError::StorageError(e))?
+            .map_err(ValidationError::StorageError)?
         {
             let header_hash = header.block_hash();
             if header_hash != chain_lock.block_hash {

dash-spv/src/client/lifecycle.rs

@@ -191,8 +191,7 @@ impl<
             // Get initial header count from storage
             let (header_height, filter_height) = {
                 let storage = self.storage.lock().await;
-                let h_height =
-                    storage.get_tip_height().await.map_err(SpvError::Storage)?.unwrap_or(0);
+                let h_height = storage.get_tip_height().await.unwrap_or(0);
                 let f_height =
                     storage.get_filter_tip_height().await.map_err(SpvError::Storage)?.unwrap_or(0);
                 (h_height, f_height)

dash-spv/src/sync/headers/manager.rs

@@ -271,14 +271,16 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
                     let first_height = storage
                         .get_start_height()
                         .await
-                        .ok_or(SyncError::Storage(format!("Failed to get start height")))?;
+                        .ok_or(SyncError::Storage("Failed to get start height".to_string()))?;
                     let checkpoint_header = storage
                         .get_header(first_height)
                         .await
                         .map_err(|e| {
                             SyncError::Storage(format!("Failed to get first header: {}", e))
                         })?
-                        .ok_or(SyncError::Storage(format!("Storage didn't return first header")))?;
+                        .ok_or(SyncError::Storage(
+                            "Storage didn't return first header".to_string(),
+                        ))?;
 
                     // Use the checkpoint hash from chain state
                     let checkpoint_hash = checkpoint_header.block_hash();
@@ -500,12 +502,12 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
         let first_height = storage
             .get_start_height()
             .await
-            .ok_or(SyncError::Storage(format!("Failed to get start height")))?;
+            .ok_or(SyncError::Storage("Failed to get start height".to_string()))?;
         let checkpoint_header = storage
             .get_header(first_height)
             .await
             .map_err(|e| SyncError::Storage(format!("Failed to get first header: {}", e)))?
-            .ok_or(SyncError::Storage(format!("Storage didn't return first header")))?;
+            .ok_or(SyncError::Storage("Storage didn't return first header".to_string()))?;
 
         let base_hash = match effective_tip_height {
             None => {
@@ -660,12 +662,12 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
             let first_height = storage
                 .get_start_height()
                 .await
-                .ok_or(SyncError::Storage(format!("Failed to get start height")))?;
+                .ok_or(SyncError::Storage("Failed to get start height".to_string()))?;
             let checkpoint_header = storage
                 .get_header(first_height)
                 .await
                 .map_err(|e| SyncError::Storage(format!("Failed to get first header: {}", e)))?
-                .ok_or(SyncError::Storage(format!("Storage didn't return first header")))?;
+                .ok_or(SyncError::Storage("Storage didn't return first header".to_string()))?;
 
             let recovery_base_hash = match current_tip_height {
                 None => {

dash-spv/tests/edge_case_filter_sync_test.rs

@@ -144,7 +144,7 @@ async fn test_filter_sync_at_tip_edge_case() {
     storage.store_filter_headers(&filter_headers).await.unwrap();
 
     // Verify initial state
-    let tip_height = storage.get_tip_height().await.unwrap().unwrap();
+    let tip_height = storage.get_tip_height().await.unwrap();
     let filter_tip_height = storage.get_filter_tip_height().await.unwrap().unwrap();
     assert_eq!(tip_height, height - 1); // 0-indexed
     assert_eq!(filter_tip_height, height - 1); // 0-indexed

dash-spv/tests/filter_header_verification_test.rs

@@ -197,7 +197,7 @@ async fn test_filter_header_verification_failure_reproduction() {
     let initial_headers = create_test_headers_range(1000, 5000); // Headers 1000-4999
     storage.store_headers(&initial_headers).await.expect("Failed to store initial headers");
 
-    let tip_height = storage.get_tip_height().await.unwrap().unwrap();
+    let tip_height = storage.get_tip_height().await.unwrap();
     println!("Initial header chain stored: tip height = {}", tip_height);
     assert_eq!(tip_height, 4999);
 
@@ -361,7 +361,7 @@ async fn test_overlapping_batches_from_different_peers() {
     let initial_headers = create_test_headers_range(1, 3000); // Headers 1-2999
     storage.store_headers(&initial_headers).await.expect("Failed to store initial headers");
 
-    let tip_height = storage.get_tip_height().await.unwrap().unwrap();
+    let tip_height = storage.get_tip_height().await.unwrap();
     println!("Header chain stored: tip height = {}", tip_height);
     assert_eq!(tip_height, 2999);
 

dash-spv/tests/rollback_test.rs

@@ -42,7 +42,7 @@ async fn test_disk_storage_rollback() -> Result<(), Box<dyn std::error::Error>>
     storage.store_headers(&headers).await?;
 
     // Verify we have 10 headers
-    let tip_height = storage.get_tip_height().await?;
+    let tip_height = storage.get_tip_height().await;
     assert_eq!(tip_height, Some(9));
 
     // Load all headers to verify
@@ -54,7 +54,7 @@ async fn test_disk_storage_rollback() -> Result<(), Box<dyn std::error::Error>>
 
     // TODO: Test assertions commented out because rollback_to_height is not implemented
     // Verify tip height is now 5
-    let _ = storage.get_tip_height().await?;
+    let _ = storage.get_tip_height().await;
     // assert_eq!(tip_height_after_rollback, Some(5));
 
     // Verify we can only load headers up to height 5