Skip to content

Commit a3d6e98

Browse files
authored
Enable source-linked deployments for apps (#3979)
## Changes Enable source-linked deployments for apps ## Why We no longer write the app.yml file from DABs, meaning the entire app source code can be "source-linked" in DABs within the workspace.
1 parent ed84fe9 commit a3d6e98

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

bundle/config/mutator/apply_source_linked_deployment_preset.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,22 +72,6 @@ func (m *applySourceLinkedDeploymentPreset) Apply(ctx context.Context, b *bundle
7272
b.Config.Presets.SourceLinkedDeployment = &enabled
7373
}
7474

75-
if len(b.Config.Resources.Apps) > 0 && config.IsExplicitlyEnabled(b.Config.Presets.SourceLinkedDeployment) {
76-
path := dyn.NewPath(dyn.Key("targets"), dyn.Key(target), dyn.Key("presets"), dyn.Key("source_linked_deployment"))
77-
diags = diags.Append(
78-
diag.Diagnostic{
79-
Severity: diag.Error,
80-
Summary: "source-linked deployment is not supported for apps",
81-
Paths: []dyn.Path{
82-
path,
83-
},
84-
Locations: b.Config.GetLocations(path[2:].String()),
85-
},
86-
)
87-
88-
return diags
89-
}
90-
9175
// This mutator runs before workspace paths are defaulted so it's safe to check for the user-defined value
9276
if b.Config.Workspace.FilePath != "" && config.IsExplicitlyEnabled(b.Config.Presets.SourceLinkedDeployment) {
9377
path := dyn.NewPath(dyn.Key("workspace"), dyn.Key("file_path"))

bundle/config/mutator/apply_source_linked_deployment_preset_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ func TestApplyPresetsSourceLinkedDeployment(t *testing.T) {
100100
},
101101
initialValue: &enabled,
102102
expectedValue: &enabled,
103-
expectedError: "source-linked deployment is not supported for apps",
104103
},
105104
{
106105
name: "preset enabled, production mode, bundle in Workspace, databricks runtime",

0 commit comments

Comments
 (0)