Skip to content

Commit 3c3a055

Browse files
authored
A couple of mypy fixes (#282)
1 parent 00804bd commit 3c3a055

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

lib/dl_core_testing/dl_core_testing/testcases/service_base.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def service_registry_factory(
182182
@pytest.fixture(scope="session")
183183
def conn_sync_service_registry(
184184
self,
185-
root_certificates,
185+
root_certificates: bytes,
186186
conn_bi_context: RequestContextInfo,
187187
) -> ServicesRegistry:
188188
return self.service_registry_factory(
@@ -195,7 +195,7 @@ def conn_sync_service_registry(
195195
@pytest.fixture(scope="session")
196196
def conn_async_service_registry(
197197
self,
198-
root_certificates,
198+
root_certificates: bytes,
199199
conn_bi_context: RequestContextInfo,
200200
# caches_redis_client_factory: Optional[Callable[[bool], Redis]], # FIXME: switch to function scope to use
201201
) -> ServicesRegistry:
@@ -250,10 +250,6 @@ def conn_default_async_us_manager(
250250
)
251251
return us_manager
252252

253-
@pytest.fixture(scope="session")
254-
def root_certificates(self) -> bytes:
255-
return get_root_certificates()
256-
257253

258254
class DbServiceFixtureTextClass(metaclass=abc.ABCMeta):
259255
conn_type: ClassVar[ConnectionType] # FIXME: Remove after conn_type is removed from Db

lib/dl_dashsql/dl_dashsql/typed_query/primitives.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ class TypedQueryParamGetter:
3737
def _default_params_by_name(self) -> Mapping[str, TypedQueryParameter]:
3838
return {param.name: param for param in self.parameters}
3939

40-
def get_opt(self, name: str, default: Optional[IncomingDSQLParamTypeExt] = None) -> Optional[TypedQueryParameter]:
41-
return self._params_by_name.get(name, default)
42-
4340
def get_strict(self, name: str) -> TypedQueryParameter:
4441
return self._params_by_name[name]
4542

0 commit comments

Comments
 (0)