Skip to content

Commit 42db624

Browse files
Include packages marked with skip_test in mypy check (#277)
1 parent 7876068 commit 42db624

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ jobs:
166166
password: ${{ secrets.GITHUB_TOKEN }}
167167
outputs:
168168
affected: ${{ steps.get_affected.outputs.affected }}
169+
all_affected_with_skips: ${{ steps.get_affected.outputs.all_affected_with_skips }}
169170
steps:
170171
- name: Cleanup build folder
171172
run: |
@@ -458,7 +459,7 @@ jobs:
458459
ref: ${{ github.event.pull_request.head.sha }}
459460
repository: ${{ github.event.pull_request.head.repo.full_name }}
460461
fetch-depth: 1
461-
- run: echo '${{ needs.router.outputs.affected }}' >> /tmp/dl_test_targets.json
462+
- run: echo '${{ needs.router.outputs.all_affected_with_skips }}' >> /tmp/dl_test_targets.json
462463
- name: run mypy
463464
run: |
464465
. /venv/bin/activate

terrarium/bi_ci/bi_ci/detect_affected_packages.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,15 @@ def main() -> None:
181181
)
182182
)
183183
result = set()
184+
skipped = set()
184185

185186
for sub in to_check:
186187
if sub.skip_test:
188+
skipped.add(str(sub.partial_parent_path))
187189
continue
188190
result.add(str(sub.partial_parent_path))
189191
print(f"affected={json.dumps(list(result))}")
192+
print(f"all_affected_with_skips={json.dumps(list(result | skipped))}")
190193

191194

192195
if __name__ == "__main__":

0 commit comments

Comments
 (0)