Make mypy green! (added per-line ignores for current errors) (#256)

Author: asnytin

lib/dl_api_client/dl_api_client/dsmaker/api/data_api.py

@@ -109,9 +109,9 @@ def save_dataset(
         dataset: Dataset,
         preview: bool = True,
         fail_ok: bool = False,
-        dir_path: str = None,
-        workbook_id: str = None,
-        created_via: str = None,
+        dir_path: str = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "dir_path" (default has type "None", argument has type "str")  [assignment]
+        workbook_id: str = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "workbook_id" (default has type "None", argument has type "str")  [assignment]
+        created_via: str = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "created_via" (default has type "None", argument has type "str")  [assignment]
         lock_timeout: int = 3,
     ) -> HttpDatasetApiResponse:
         dataset.prepare()
@@ -191,7 +191,7 @@ def copy_dataset(
         data = {"new_key": new_key}
 
         response = self._request(f"/api/v1/datasets/{dataset.id}/copy", method="post", data=data)
-        assert response.status_code == 200, f"Dataset copy fail: {response.data}"
+        assert response.status_code == 200, f"Dataset copy fail: {response.data}"  # type: ignore  # 2024-01-24 # TODO: If x = b'abc' then f"***x***" or "***".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"***x!r***" or "***!r***".format(x). Otherwise, decode the bytes  [str-bytes-safe]
         dataset = self.serial_adapter.load_dataset_from_response_body(dataset=dataset, body=response.json)
         return HttpDatasetApiResponse(
             json=response.json,
@@ -212,7 +212,7 @@ def load_dataset(self, dataset: Dataset) -> HttpDatasetApiResponse:
     def apply_updates(  # type: ignore  # TODO: fix
         self,
         dataset: Dataset,
-        updates: list[Union[UpdateAction, dict]] = None,
+        updates: list[Union[UpdateAction, dict]] = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "updates" (default has type "None", argument has type "list[UpdateAction | dict[Any, Any]]")  [assignment]
         fail_ok: bool = False,
     ) -> HttpDatasetApiResponse:
         if dataset.created_:
@@ -221,7 +221,7 @@ def apply_updates(  # type: ignore  # TODO: fix
             url = "/api/v1/datasets/validators/dataset"
 
         data = self.dump_dataset_to_request_body(dataset)
-        updates = list(updates or ()) + self.serial_adapter.generate_implicit_updates(dataset)
+        updates = list(updates or ()) + self.serial_adapter.generate_implicit_updates(dataset)  # type: ignore  # 2024-01-24 # TODO: Unsupported operand types for + ("list[UpdateAction | dict[Any, Any]]" and "list[UpdateAction]")  [operator]
         data["updates"] = self.serial_adapter.dump_updates(updates)
         response = self._request(url, method="post", data=data)
 
@@ -232,7 +232,7 @@ def apply_updates(  # type: ignore  # TODO: fix
             try:
                 assert response.status_code == HTTPStatus.OK, response.json
             except AssertionError:
-                print("\n".join(HttpApiResponse.extract_response_errors(response)))
+                print("\n".join(HttpApiResponse.extract_response_errors(response)))  # type: ignore  # 2024-01-24 # TODO: Argument 1 to "extract_response_errors" of "HttpApiResponse" has incompatible type "ClientResponse"; expected "dict[str, Any]"  [arg-type]
                 raise
 
         if "dataset" in response.json:

lib/dl_api_client/dl_api_client/dsmaker/api/dataset_api.py

@@ -45,7 +45,7 @@ async def _request(
         method: str,
         data: Optional[dict] = None,
         headers: Optional[dict] = None,
-        lock_timeout: int = None,
+        lock_timeout: int = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "lock_timeout" (default has type "None", argument has type "int")  [assignment]
     ) -> ClientResponse:
         data_str: Optional[str] = None
         content_type: Optional[str] = None
@@ -72,7 +72,7 @@ async def send_request() -> ClientResponse:
 
         while response.status_code == HTTPStatus.LOCKED and lock_timeout and time.monotonic() - started < lock_timeout:
             await asyncio.sleep(0.3)
-            response = send_request()
+            response = send_request()  # type: ignore  # 2024-01-24 # TODO: Incompatible types in assignment (expression has type "Coroutine[Any, Any, ClientResponse]", variable has type "ClientResponse")  [assignment]
 
         return response
 

lib/dl_api_client/dl_api_client/dsmaker/api/http_async_base.py

@@ -97,7 +97,7 @@ def _request(
         method: str,
         data: Optional[dict] = None,
         headers: Optional[dict] = None,
-        lock_timeout: int = None,
+        lock_timeout: int = None,  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "lock_timeout" (default has type "None", argument has type "int")  [assignment]
     ) -> ClientResponse:
         data_str: Optional[str] = None
         content_type: Optional[str] = None

lib/dl_api_client/dl_api_client/dsmaker/api/http_sync_base.py

@@ -21,7 +21,7 @@ class Meta:
 
 
 class DefaultSchema(BaseSchema, Generic[_TARGET_OBJECT_TV]):
-    TARGET_CLS: ClassVar[Type[_TARGET_OBJECT_TV]]
+    TARGET_CLS: ClassVar[Type[_TARGET_OBJECT_TV]]  # type: ignore  # 2024-01-24 # TODO: ClassVar cannot contain type variables  [misc]
 
     @classmethod
     def get_target_cls(cls) -> Type[_TARGET_OBJECT_TV]:

lib/dl_api_client/dl_api_client/dsmaker/api/schemas/base.py

@@ -359,7 +359,7 @@ class AfterBlockPlacementSchema(BlockPlacementSchema):
     dimension_values = ma_fields.Nested(DimensionValueSpecSchema, many=True, allow_none=True)
 
 
-class BlockPlacementSchema(OneOfSchema):
+class BlockPlacementSchema(OneOfSchema):  # type: ignore  # 2024-01-24 # TODO: Name "BlockPlacementSchema" already defined on line 350  [no-redef]
     class Meta:
         unknown = EXCLUDE
 

lib/dl_api_client/dl_api_client/dsmaker/api/schemas/data.py

@@ -172,7 +172,7 @@ class ValueSchema(OneOfSchemaWithDumpLoadHooks):
         UserDataType.array_str.name: ArrayStrValueSchema,
         UserDataType.array_int.name: ArrayIntValueSchema,
         UserDataType.array_float.name: ArrayFloatValueSchema,
-        UserDataType.tree_str.name: TreeStrParameterValue,
+        UserDataType.tree_str.name: TreeStrParameterValue,  # type: ignore  # 2024-01-24 # TODO: Dict entry 15 has incompatible type "str": "type[TreeStrParameterValue]"; expected "str": "type[Schema]"  [dict-item]
     }
 
     @pre_load(pass_many=False)

lib/dl_api_client/dl_api_client/dsmaker/api/schemas/dataset.py

@@ -47,7 +47,7 @@ class ObligatoryFilterUpdateSchema(DefaultSchema[ObligatoryFilter]):
 class BaseApiV1SerializationAdapter:
     # TODO: switch to marshmallow
 
-    def dump_item(self, item: ApiProxyObject, action: Action = None) -> dict:
+    def dump_item(self, item: ApiProxyObject, action: Action = None) -> dict:  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "action" (default has type "None", argument has type "Action")  [assignment]
         """
         Dump item data for API request. Return dict
 
@@ -69,7 +69,7 @@ def dump_data_source(self, item: DataSource, action: Action) -> dict:
             return dict(
                 id=item.id,
                 connection_id=item.connection_id,
-                source_type=item.source_type.name,
+                source_type=item.source_type.name,  # type: ignore  # 2024-01-24 # TODO: Item "None" of "DataSourceType | None" has no attribute "name"  [union-attr]
                 title=item.title,
                 raw_schema=[
                     dict(
@@ -170,7 +170,7 @@ def dump_field(self, item: ResultField, action: Action) -> dict:
             return dict(guid=item.id)
 
     @_dump_item.register(ObligatoryFilter)
-    def dump_obligatory_filter(self, item: ObligatoryFilter, action: Action = None) -> dict:
+    def dump_obligatory_filter(self, item: ObligatoryFilter, action: Action = None) -> dict:  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "action" (default has type "None", argument has type "Action")  [assignment]
         if action == Action.delete:
             return dict(id=item.id)
         if action == Action.add:
@@ -223,7 +223,7 @@ def _get_action_postfix(item: ApiProxyObject) -> str:
             ObligatoryFilter: "obligatory_filter",
         }[type(item)]
 
-    def dump_updates(self, updates: List[Union[UpdateAction, dict]] = None) -> List[dict]:
+    def dump_updates(self, updates: List[Union[UpdateAction, dict]] = None) -> List[dict]:  # type: ignore  # 2024-01-24 # TODO: Incompatible default for argument "updates" (default has type "None", argument has type "list[UpdateAction | dict[Any, Any]]")  [assignment]
         result = []
         for update in updates or ():
             if isinstance(update, UpdateAction):

lib/dl_api_client/dl_api_client/dsmaker/api/serialization_base.py

@@ -89,7 +89,7 @@ def split_row_by_measures(self, raw_row: ResultRawDataRow) -> Generator[tuple[Da
             dim_tuple = DataCellTuple(
                 tuple(sorted(chain(dimension_cells + (mname_cell,)), key=lambda cell: cell.title))
             )
-            yield dim_tuple, DataItem(cell=measure_cell, meta=DataItemMeta(tags=frozenset(tags)))
+            yield dim_tuple, DataItem(cell=measure_cell, meta=DataItemMeta(tags=frozenset(tags)))  # type: ignore  # 2024-01-24 # TODO: Incompatible types in "yield" (actual type "tuple[DataCellTuple, DataItem]", expected type "tuple[DataCellTuple, DataCell]")  [misc]
 
 
 @attr.s
@@ -134,7 +134,7 @@ def get_1d_mapper(
     ) -> DataCellMapper1D:
         return SimpleDataCellMapper1D(
             cells={
-                dim_tuple: cell
+                dim_tuple: cell  # type: ignore  # 2024-01-24 # TODO: Value expression in dictionary comprehension has incompatible type "DataCell"; expected type "DataItem"  [misc]
                 for dim_tuple, cell in self._iter_split_rows_by_measure(
                     dimension_liids=dimension_liids,
                     measure_liids=measure_liids,

lib/dl_api_client/dl_api_client/dsmaker/data_abstraction/result.py

@@ -168,7 +168,7 @@ def make_pivot_item(
                 role=role,
                 legend_item_ids=legend_item_ids,
                 title=remapped_title,
-                direction=order_fields.get(title, OrderDirection.asc),
+                direction=order_fields.get(title, OrderDirection.asc),  # type: ignore  # 2024-01-24 # TODO: Argument "direction" to "make_req_pivot_item" of "Dataset" has incompatible type "OrderDirection | None"; expected "OrderDirection"  [arg-type]
             )
         if role == PivotRole.pivot_measure:
             return dataset.make_req_pivot_item(
@@ -187,7 +187,7 @@ def order_by_item(title: str, direction: OrderDirection) -> OrderedField:
 
     pivot_resp = data_api.get_pivot(
         dataset=dataset,
-        fields=legend,
+        fields=legend,  # type: ignore  # 2024-01-24 # TODO: Argument "fields" to "get_pivot" of "SyncHttpDataApiV2" has incompatible type "list[RequestLegendItem]"; expected "list[ResultField | RequestLegendItem] | None"  [arg-type]
         pivot_structure=[
             *[make_pivot_item(title=title, role=PivotRole.pivot_column) for title in columns],
             *[make_pivot_item(title=title, role=PivotRole.pivot_row) for title in rows],
@@ -199,7 +199,7 @@ def order_by_item(title: str, direction: OrderDirection) -> OrderedField:
             ],
             *[make_pivot_item(title=title, role=PivotRole.pivot_annotation) for title in annotations or ()],
         ],
-        order_by=[order_by_item(title=title, direction=direction) for title, direction in (order_fields or {}).items()],
+        order_by=[order_by_item(title=title, direction=direction) for title, direction in (order_fields or {}).items()],  # type: ignore  # 2024-01-24 # TODO: Argument "direction" to "order_by_item" has incompatible type "OrderDirection | None"; expected "OrderDirection"  [arg-type]
         filters=filters,
         pivot_pagination=pivot_pagination,
         pivot_totals=simple_totals,
@@ -321,7 +321,7 @@ def norm_title(title: str) -> str:
         totals=check_totals,
     )
     legend_for_result = [item for item in legend if item.ref.type != QueryItemRefType.measure_name]
-    result_resp = data_api.get_result(dataset=dataset, fields=legend_for_result, filters=filters, fail_ok=True)
+    result_resp = data_api.get_result(dataset=dataset, fields=legend_for_result, filters=filters, fail_ok=True)  # type: ignore  # 2024-01-24 # TODO: Argument "fields" to "get_result" of "SyncHttpDataApiV2" has incompatible type "list[RequestLegendItem]"; expected "list[ResultField | RequestLegendItem] | None"  [arg-type]
     assert result_resp.status_code == HTTPStatus.OK, result_resp.json
 
     result_mapper_measure_liids = frozenset(
@@ -335,7 +335,7 @@ def norm_title(title: str) -> str:
     pivot_data_abstraction = PivotDataAbstraction.from_response(pivot_resp)
     pivot_data_mapper: DataCellMapper1D = pivot_data_abstraction.get_1d_mapper()
 
-    def _is_total(dimension: Optional[list], totals_liids: set[int]):
+    def _is_total(dimension: Optional[list], totals_liids: set[int]):  # type: ignore  # 2024-01-24 # TODO: Function is missing a return type annotation  [no-untyped-def]
         return dimension is not None and any(value[0][1] in totals_liids for value in dimension)
 
     totals_liids = {