Skip to content

Commit f2ebb16

Browse files
authored
fix: BI-0 update temporal client defaults (#1385)
1 parent 7b70013 commit f2ebb16

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

lib/dl_temporal/dl_temporal/client/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
class TemporalClientSettings(dl_settings.BaseSettings):
2121
HOST: str
22-
PORT: int
23-
TLS: bool
22+
PORT: int = 7233
23+
TLS: bool = True
2424
NAMESPACE: str
2525
METADATA_PROVIDER: dl_settings.TypedAnnotation[metadata.MetadataProviderSettings]
2626

@@ -30,7 +30,7 @@ class TemporalClientDependencies:
3030
namespace: str
3131
host: str
3232
port: int = 7233
33-
tls: bool = False
33+
tls: bool = True
3434
lazy: bool = True
3535
metadata_provider: metadata.MetadataProvider = attrs.field(factory=metadata.EmptyMetadataProvider)
3636

lib/dl_temporal/dl_temporal_tests/db/client/test_check_health.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ async def test_unavailable() -> None:
1515
dependencies=dl_temporal.TemporalClientDependencies(
1616
host="unavailable_host",
1717
port=8080,
18+
tls=False,
1819
namespace="dl_temporal_tests",
1920
),
2021
)

lib/dl_temporal/dl_temporal_tests/db/client/test_metadata.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ async def test_ttl(
2121
dependencies=dl_temporal.TemporalClientDependencies(
2222
host="test-host",
2323
port=1234,
24+
tls=False,
2425
namespace="test-namespace",
2526
metadata_provider=metadata_provider,
2627
),

lib/dl_temporal/dl_temporal_tests/db/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ async def fixture_temporal_client(
4444
host=temporal_hostport.host,
4545
port=temporal_hostport.port,
4646
namespace=temporal_namespace,
47+
tls=False,
4748
lazy=False,
4849
)
4950
)

0 commit comments

Comments
 (0)