Document that GroupId attribute cannot override parent Group in UserPrivileges:LocalGroupMember

[garymazz]

Hi,

I received an error "The UserPrivileges:LocalGroupMember element contains an unexpected attribute 'GroupId'."

From the doc it appears GroupId attribute is valid.

Can you tell me what I'm doing wrong ?

          <UserPrivileges:LocalGroupMember 
            Id="assign.SYS.ADMIN.GRP.USER" 
            UserId="USER" 
            GroupId="Administrators"
            AddOnInstall="yes" 
            RemoveOnUnInstall="yes" 
            CheckIfMember="yes" 
          />

[dblock]

That's strange, it's even used in demos, like here, maybe you can compare with that?

[garymazz]

It is,, I lifted the code from your example.. :) I thought tags were evaluated individually.

BTW, where is you schema ?

Here is the component:

      <Component Id="create.ADMIN.GRP.USER" Guid="{Some_GUID}">
          <UserPrivileges:LocalUser 
            Id="ADMIN.USER" 
            Username="$(var.Admin.Name)" 
            Password="$(var.Admin.Password)" 
            CreateOnInstall="yes" 
            DeleteOnUnInstall="yes" 
            CheckIfExists="yes" 
          />
          <UserPrivileges:LocalGroup 
            Id="ADMIN.GRP" 
            Name="$(var.Admin.Group)" 
            Description="$(var.Admin.Group.Desc)" 
            CheckIfExists="yes" 
            CreateOnInstall="yes" 
            DeleteOnUnInstall="yes"
          >
            <UserPrivileges:LocalGroupMember 
              Id="assign.ADMIN.GRP.USER" 
              UserId="ADMIN.USER" 
              AddOnInstall="yes" 
              RemoveOnUnInstall="yes" 
              CheckIfMember="yes" 
            />
            <UserPrivileges:LocalGroupMember 
              Id="assign.SYS.ADMIN.GRP.USER" 
              UserId="ADMIN.USER" 
              GroupId="Administrators"
              AddOnInstall="yes" 
              RemoveOnUnInstall="yes" 
              CheckIfMember="yes" 
            />
            <UserPrivileges:LocalGroupMember 
              Id="remove.ADMIN.GRP.USER" 
              UserId="ADMIN.USER" 
              GroupId="Users"
              RemoveOnInstall="yes" 
              CheckIfMember="yes" 
           />
        </UserPrivileges:LocalGroup>
    </Component>

[garymazz]

I did a bit more playing with the issue. It seems LocalGroupMember does not support a GroupId overide for when nested under local group. When I move the LocalGroupMember outside of LocalGroup nesting, the unexpected GroupId error is resolved; only to be replaced with another error..

You may consider "fixing" this with some documentation :) It's be easier for you than me (sorry)

[dblock]

That makes sense! The schema is here.

[dblock]

Of course it'd be easier for me to do it @garymazz because you wouldn't have to do it :) It works both ways. Thanks for surfacing this either way.

[garymazz]

Thanks for running with this. I'm very late on a deadline and need to fix issues in several open source projects, 4 alone with installation and a CI system. My issue is time, coming up to speed on all these OSS projects simultaneously.-, plus getting something to ship. After next friday, I'll have breathing room..

[garymazz]

After going though UserPrivilegesCompiler.cs, I understood how UserId and GroupId worked. There is no overrides for GroupId when LocalGroupMember nested under LocalGroup. There is no override for UserId when nested under LocalUser. Both are just syntactic candy. I'll update the doc and add some comments to your examples as soon as I get the project building on VS 2015.