diff --git a/kur/utils/package.py b/kur/utils/package.py index a35997a..9c815ed 100644 --- a/kur/utils/package.py +++ b/kur/utils/package.py @@ -96,7 +96,26 @@ def link_is_safe(member): (allow_outside_links or link_is_safe(member)) ] # Extract the safe members - tar.extractall(path=dest, members=members) +def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + +def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + +safe_extract(tar, path=dest, members=members) # Return the list of file paths. return [canonicalize(os.path.join(dest, member.name)) for member in members]