Skip to content

is_voxel_in_bounds for 2d uses wrong index #369

@shadowcatzero

Description

@shadowcatzero

key[0] >= self.domain_mins[1]

I'm pretty sure the 1 there is not intended (should be 0 to compare with min x). I'm using rapier and wrote my own method that does that + try_set_voxel which worked; originally it wasn't able to resize in the -x direction under certain circumstances as you'd expect. It looks like a place you may wanna use [T; N]::map instead to make it harder to mess up, but I don't know the performance implications nor does it seem like [T;N]::all exists.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions