-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(guide): updated modal page for label #11169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
thorminate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, my grammar review is done.
apps/guide/content/docs/legacy/interactive-components/select-menus.mdx
Outdated
Show resolved
Hide resolved
apps/guide/content/docs/legacy/interactive-components/select-menus.mdx
Outdated
Show resolved
Hide resolved
apps/guide/content/docs/legacy/interactive-components/select-menus.mdx
Outdated
Show resolved
Hide resolved
apps/guide/content/docs/legacy/interactive-components/select-menus.mdx
Outdated
Show resolved
Hide resolved
apps/guide/content/docs/legacy/interactive-components/select-menus.mdx
Outdated
Show resolved
Hide resolved
apps/guide/content/docs/legacy/popular-topics/display-components.mdx
Outdated
Show resolved
Hide resolved
almostSouji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give this another read-over in terms of reading flow and grammar. I tried to cover everything that wasn't already pointed out, but after applying reviews, this may require some additional or different changes to read well.
Please also review heading nesting levels and make sure they nest as they should (H3 > H4, H4 etc.).
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
almeidx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤠
Please describe the changes this PR makes and why it should be merged:
Update of Modal interaction page to reflect the addition of label, Text Display and Select Menu components
Status and versioning classification:
In Development