Skip to content

Commit e4b7c71

Browse files
Update test messages to use indexes
1 parent 7a629c5 commit e4b7c71

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

pkg/api/pagination_test.go

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func createTestMessages(count int) []session.Message {
2424
AgentName: "test",
2525
Message: chat.Message{
2626
Role: role,
27-
Content: "Message " + string(rune('A'+i)),
27+
Content: "Message " + strconv.Itoa(i),
2828
CreatedAt: time.Now().Add(time.Duration(i) * time.Second).Format(time.RFC3339),
2929
},
3030
}
@@ -49,12 +49,10 @@ func TestPaginateMessages_FirstPage(t *testing.T) {
4949
// Should get most recent 10 messages (for chat infinite scroll)
5050
// For 100 messages, indices 90-99 should be returned
5151
// Check that we got recent messages by verifying they're different from the old first messages
52-
assert.NotEqual(t, "Message A", paginated[0].Message.Content) // Not the oldest message
53-
assert.NotEqual(t, "Message J", paginated[9].Message.Content) // Not the 10th oldest message
54-
55-
// Verify these are actually the last 10 messages by checking against known patterns
56-
// The createTestMessages function creates "Message " + char, where char is 'A' + index
57-
// So message 90 would be beyond normal ASCII range, let's just verify the structure
52+
assert.NotEqual(t, "Message 0", paginated[0].Message.Content) // Not the oldest message
53+
assert.NotEqual(t, "Message 9", paginated[9].Message.Content) // Not the 10th oldest message
54+
assert.Equal(t, "Message 90", paginated[0].Message.Content) // Index 90
55+
assert.Equal(t, "Message 99", paginated[9].Message.Content) // Index 99
5856
}
5957

6058
func TestPaginateMessages_WithBeforeCursorPagination(t *testing.T) {
@@ -70,8 +68,8 @@ func TestPaginateMessages_WithBeforeCursorPagination(t *testing.T) {
7068

7169
// Verify we got the end page
7270
assert.Len(t, endPage, 10)
73-
assert.Equal(t, "Message K", endPage[0].Message.Content) // Index 10 = 'K'
74-
assert.Equal(t, "Message T", endPage[9].Message.Content) // Index 19 = 'T'
71+
assert.Equal(t, "Message 10", endPage[0].Message.Content) // Index 10
72+
assert.Equal(t, "Message 19", endPage[9].Message.Content) // Index 19
7573

7674
// Get previous page using before cursor (should give us messages 0-9)
7775
prevPageParams := PaginationParams{
@@ -85,8 +83,8 @@ func TestPaginateMessages_WithBeforeCursorPagination(t *testing.T) {
8583
assert.Empty(t, prevMeta.PrevCursor) // No more older messages
8684

8785
// Should get messages 0-9
88-
assert.Equal(t, "Message A", prevPage[0].Message.Content) // Index 0 = 'A'
89-
assert.Equal(t, "Message J", prevPage[9].Message.Content) // Index 9 = 'J'
86+
assert.Equal(t, "Message 0", prevPage[0].Message.Content) // Index 0
87+
assert.Equal(t, "Message 9", prevPage[9].Message.Content) // Index 9
9088

9189
// No overlap between pages
9290
assert.NotEqual(t, endPage[0].Message.Content, prevPage[9].Message.Content)
@@ -110,8 +108,8 @@ func TestPaginateMessages_WithBeforeCursor(t *testing.T) {
110108
assert.NotEmpty(t, meta.PrevCursor) // There are older messages
111109

112110
// Should get 10 messages before index 50 (indices 40-49)
113-
assert.Equal(t, "Message "+string(rune('A'+40)), paginated[0].Message.Content)
114-
assert.Equal(t, "Message "+string(rune('A'+49)), paginated[9].Message.Content)
111+
assert.Equal(t, "Message "+strconv.Itoa(40), paginated[0].Message.Content)
112+
assert.Equal(t, "Message "+strconv.Itoa(49), paginated[9].Message.Content)
115113
}
116114

117115
func TestPaginateMessages_DefaultLimit(t *testing.T) {
@@ -173,8 +171,8 @@ func TestPaginateMessages_LastPage(t *testing.T) {
173171
assert.Equal(t, 25, lastMeta.TotalMessages)
174172

175173
// Should get the first 5 messages
176-
assert.Equal(t, "Message A", lastPage[0].Message.Content)
177-
assert.Equal(t, "Message E", lastPage[4].Message.Content)
174+
assert.Equal(t, "Message 0", lastPage[0].Message.Content)
175+
assert.Equal(t, "Message 4", lastPage[4].Message.Content)
178176
}
179177

180178
func TestPaginateMessages_BeforeFirstMessage(t *testing.T) {

0 commit comments

Comments
 (0)