cli/command/container: don't depend on result.OSType #6581
Merged
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is set for the request as a whole, so can be obtained from the server-info instead. Docker v29 will provide per-stats information. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
stats_ostype
branch
from
3dd0a32 to
4b498ad
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the docker stats command to obtain the daemon OS type from server info at the start of execution, rather than extracting it from individual stats responses. This change prepares the codebase for Docker v29, which will provide per-stats OS type information.
- Moved
daemonOSTypeinitialization to the beginning ofRunStats()usingdockerCLI.ServerInfo().OSType - Removed the assignment of
daemonOSTypefrom individual stats responses in thecollect()function - Eliminated the fallback OS type check that was previously done after stats collection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/command/container/stats.go | Initializes daemonOSType at function start and removes the fallback check after stats collection |
| cli/command/container/stats_helpers.go | Removes the per-response assignment of daemonOSType in the stats collection loop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
austinvazquez
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is set for the request as a whole, so can be obtained from the server-info instead. Docker v29 will provide per-stats information.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)