test digest or canonical reference, not only tag, when checking if an image is already present

glours · ndeloof · commit da5c57c29d4d · 2025-10-20T18:42:24.000+02:00
Signed-off-by: Guillaume Lours &lt;705411+glours@users.noreply.github.com&gt;
diff --git a/pkg/compose/pull.go b/pkg/compose/pull.go
@@ -159,12 +159,14 @@ func imageAlreadyPresent(serviceImage string, localImages map[string]api.ImageSu
 	if err != nil {
 		return false
 	}
-	tagged, ok := normalizedImage.(reference.NamedTagged)
-	if !ok {
-		return false
+	switch refType := normalizedImage.(type) {
+	case reference.NamedTagged:
+		_, ok := localImages[serviceImage]
+		return ok && refType.Tag() != "latest"
+	default:
+		_, ok := localImages[serviceImage]
+		return ok
 	}
-	_, ok = localImages[serviceImage]
-	return ok && tagged.Tag() != "latest"
 }
 
 func getUnwrappedErrorMessage(err error) string {

Original file line number	Diff line number	Diff line change
`@@ -159,12 +159,14 @@ func imageAlreadyPresent(serviceImage string, localImages map[string]api.ImageSu`
`159`	`159`	`if err != nil {`
`160`	`160`	`return false`
`161`	`161`	`}`
`162`		`- tagged, ok := normalizedImage.(reference.NamedTagged)`
`163`		`- if !ok {`
`164`		`- return false`
	`162`	`+ switch refType := normalizedImage.(type) {`
	`163`	`+ case reference.NamedTagged:`
	`164`	`+ _, ok := localImages[serviceImage]`
	`165`	`+ return ok && refType.Tag() != "latest"`
	`166`	`+ default:`
	`167`	`+ _, ok := localImages[serviceImage]`
	`168`	`+ return ok`
`165`	`169`	`}`
`166`		`- _, ok = localImages[serviceImage]`
`167`		`- return ok && tagged.Tag() != "latest"`
`168`	`170`	`}`
`169`	`171`
`170`	`172`	`func getUnwrappedErrorMessage(err error) string {`