Skip to content

Commit 162e608

Browse files
authored
Merge pull request #3 from dockersamples/fix-launch-buttons
Show "Starting..." only on the Labspace that's being started
2 parents da3649d + 0323f53 commit 162e608

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ LABEL org.opencontainers.image.title="Labspaces" \
2323
com.docker.extension.publisher-url="https://github.com/dockersamples/labspace-extension" \
2424
com.docker.extension.additional-urls="[{\"title\":\"Create your own Labspace\",\"url\":\"https://github.com/dockersamples/labspace-starter\"}]" \
2525
com.docker.extension.categories="cloud-development" \
26-
com.docker.extension.changelog="Initial release"
26+
com.docker.extension.changelog="Fix bug that was showing \"Starting...\" label for all Labspaces instead of only the one being started"
2727
COPY beaker.svg /
2828
COPY metadata.json /
2929
COPY --from=build /usr/local/app/dist /ui

src/components/LabspaceCard.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ export function LabspaceCard({ labspace }) {
3434
onClick={() => startLabspace(labspace.publishedRepo)}
3535
disabled={startingLabspace || runningLabspace}
3636
>
37-
{startingLabspace ? "Starting..." : "Launch"}
37+
{startingLabspace === labspace.publishedRepo
38+
? "Starting..."
39+
: "Launch"}
3840
</Button>
3941
</div>
4042
</Card.Footer>

0 commit comments

Comments
 (0)