feat: add clear icon on defined name comment; fix: overlaying a value on clear icon #6043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
I noticed that the values in the input that have an icon for clearing the value overlap the icon itself. It's clickable, but I don't think that's supposed to happen. I noticed that there's already logic regarding the right margin for slots, so I decided to use a separate useEffect and add a check that would not conflict with slots, also in [] I deliberately did not add allowClear, since this caused an extra trigger, since the first time the value was entered, an indent would still be needed.
I also found it strange that the name itself had this icon in defined names, but the comment didn't have it.
Before:

After: -->

Pull Request Checklist