Skip to content

Conversation

@kenny-not-dead
Copy link
Contributor

close #xxx

I noticed that the values ​​in the input that have an icon for clearing the value overlap the icon itself. It's clickable, but I don't think that's supposed to happen. I noticed that there's already logic regarding the right margin for slots, so I decided to use a separate useEffect and add a check that would not conflict with slots, also in [] I deliberately did not add allowClear, since this caused an extra trigger, since the first time the value was entered, an indent would still be needed.

I also found it strange that the name itself had this icon in defined names, but the comment didn't have it.

Before:
image

After: -->
image

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.22%. Comparing base (04e1d05) to head (73d4987).
⚠️ Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6043      +/-   ##
==========================================
- Coverage   33.24%   33.22%   -0.02%     
==========================================
  Files        2763     2763              
  Lines      145747   145749       +2     
  Branches    32529    32530       +1     
==========================================
- Hits        48447    48431      -16     
- Misses      97300    97318      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jikkai jikkai merged commit 1748f5f into dream-num:dev Oct 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants