Skip to content

Passing an array to no-data doesn't work #47

@j3j5

Description

@j3j5

Hi, I'm using this package but I just noticed that passing an array to no-data option in the settings (as stated on the readme) doesn't prevent the tables on the array from dumping their data.

I've tracked the issue and it seems to come from this line, which checks whether no-data is enabled, which, in this case returns false because isEnabled() does a strict check with true, and $this->settings[no-data] is an array.

I can create a PR if you want, but I'm not sure why the check is there on the first place (there's a comment saying // don't break compatibility with old trigger) , so I'm not sure what the best solution would be, suggestions welcome.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions