Fix Go err race (#3243)

Author: r4victor

runner/cmd/runner/main.go

@@ -28,9 +28,9 @@ func start(tempDir string, homeDir string, httpPort int, sshPort int, logLevel i
 		return fmt.Errorf("create default log file: %w", err)
 	}
 	defer func() {
-		err = defaultLogFile.Close()
-		if err != nil {
-			log.Error(context.TODO(), "Failed to close default log file", "err", err)
+		closeErr := defaultLogFile.Close()
+		if closeErr != nil {
+			log.Error(context.TODO(), "Failed to close default log file", "err", closeErr)
 		}
 	}()
 

runner/internal/executor/executor.go

@@ -422,8 +422,8 @@ func (ex *RunExecutor) execJob(ctx context.Context, jobLogFile io.Writer) error
 	cmd := exec.CommandContext(ctx, ex.jobSpec.Commands[0], ex.jobSpec.Commands[1:]...)
 	cmd.Cancel = func() error {
 		// returns error on Windows
-		if err = cmd.Process.Signal(os.Interrupt); err != nil {
-			return fmt.Errorf("send interrupt signal: %w", err)
+		if signalErr := cmd.Process.Signal(os.Interrupt); signalErr != nil {
+			return fmt.Errorf("send interrupt signal: %w", signalErr)
 		}
 		return nil
 	}

runner/internal/shim/host_info.go

@@ -24,7 +24,7 @@ type hostInfo struct {
 func WriteHostInfo(dir string, resources Resources) error {
 	path := filepath.Join(dir, "host_info.json")
 	// if host_info.json already exists, do nothing and return os.ErrExist
-	if _, err := os.Stat(path); errors.Is(err, os.ErrExist) {
+	if _, err := os.Stat(path); !errors.Is(err, os.ErrNotExist) {
 		return err
 	}