dev: fix script parameters #16523
Merged
dev: fix script parameters #16523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Npm scripts which delegate to other npm scripts need to use '--' to forward parameters to the invoked script. This fix makes sure to add argument forwarding to all relevant scripts.
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Npm scripts which delegate to other npm scripts need to use
--to forward parameters to the invoked script. This fix makes sure to add argument forwarding to all relevant scripts.How to test
npm start:debugin the Browser and/or Electron examplelog-level=debugis lostFollow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers